[webkit-changes] [WebKit/WebKit] 2fa562: testharness.js tests do not work when loaded in cr...

Kimmo Kinnunen noreply at github.com
Mon Sep 23 10:49:04 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2fa5620a0732536cd1601232eb89ab07654ef4cf
      https://github.com/WebKit/WebKit/commit/2fa5620a0732536cd1601232eb89ab07654ef4cf
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M LayoutTests/resources/testharnessreport.js
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  testharness.js tests do not work when loaded in cross-origin iframes
https://bugs.webkit.org/show_bug.cgi?id=280048
rdar://136347990

Reviewed by Alex Christensen.

Add a url parameter inCrossOriginFrame=true to the iframe src that
is used for the WebKitTestRunner cross-origin frame test mode.

The WebKit specific testharnessreport.js contains a filter that no-ops
test completion reports if the test is loaded from an iframe. Avoid
this filter if the document is indeed the main document, loaded from
the cross-origin frame.

Fixes testharness.js test timeouts with run-webkit-tests --site-isolation.

* LayoutTests/resources/testharnessreport.js:
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::loadTestInCrossOriginIframe):

Canonical link: https://commits.webkit.org/284092@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list