[webkit-changes] [WebKit/WebKit] 2f6436: RenderMultiColumnFlow: don't allocate m_spannerMap...

Kiet Ho noreply at github.com
Mon Sep 23 10:38:39 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f64361f2310d4e4c22414c69f3c5d23be7abf19
      https://github.com/WebKit/WebKit/commit/2f64361f2310d4e4c22414c69f3c5d23be7abf19
  Author: Kiet Ho <kiet.ho at apple.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderMultiColumnFlow.cpp
    M Source/WebCore/rendering/RenderMultiColumnFlow.h

  Log Message:
  -----------
  RenderMultiColumnFlow: don't allocate m_spannerMap on the heap
rdar://136444038
https://bugs.webkit.org/show_bug.cgi?id=280146

Reviewed by Antti Koivisto.

m_spannerMap is currently heap-allocated in a std::unique_ptr. Before, this
was needed to be able to take ownership of m_spannerMap, but that code was
removed and there are no reasons to heap-allocate m_spannerMap anymore.

* Source/WebCore/rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow):
(WebCore::RenderMultiColumnFlow::findColumnSpannerPlaceholder const):
* Source/WebCore/rendering/RenderMultiColumnFlow.h:

Canonical link: https://commits.webkit.org/284090@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list