[webkit-changes] [WebKit/WebKit] 44c025: Move wasm refs back to Int64s on 32-bits.

[aoikonomopoulos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 44c025ed741044b0f38d69a10039c0b15be099d2
      https://github.com/WebKit/WebKit/commit/44c025ed741044b0f38d69a10039c0b15be099d2
  Author: Angelos Oikonomopoulos <angelos at igalia.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp
    M Source/JavaScriptCore/wasm/wasm.json

  Log Message:
  -----------
  Move wasm refs back to Int64s on 32-bits.
https://bugs.webkit.org/show_bug.cgi?id=279977

Reviewed by Justin Michaud and Keith Miller.

Lots of generic code carries the assumption that refs are stored as
EncodedJSValues. In the interest of getting things working, change
wasm.json to use Int64 for refs (rather than pointerType()).

Update ref-accessing code in WasmOMGIRGenerator32_64.cpp to match.

* Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp:
(JSC::Wasm::OMGIRGenerator::addRefIsNull):
(JSC::Wasm::OMGIRGenerator::addTableGet):
(JSC::Wasm::OMGIRGenerator::addRefAsNonNull):
(JSC::Wasm::OMGIRGenerator::addI31GetS):
(JSC::Wasm::OMGIRGenerator::addI31GetU):
(JSC::Wasm::OMGIRGenerator::pushArrayNew):
(JSC::Wasm::OMGIRGenerator::addArrayGet):
(JSC::Wasm::OMGIRGenerator::emitArrayNullCheck):
(JSC::Wasm::OMGIRGenerator::addArrayLen):
(JSC::Wasm::OMGIRGenerator::addStructNew):
(JSC::Wasm::OMGIRGenerator::addStructNewDefault):
(JSC::Wasm::OMGIRGenerator::addStructGet):
(JSC::Wasm::OMGIRGenerator::addStructSet):
(JSC::Wasm::OMGIRGenerator::emitRefTestOrCast):
(JSC::Wasm::OMGIRGenerator::addBranchNull):
(JSC::Wasm::OMGIRGenerator::addCallRef):
* Source/JavaScriptCore/wasm/wasm.json:

Canonical link: https://commits.webkit.org/284070@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications