[webkit-changes] [WebKit/WebKit] e9c4d2: Cherry-pick 283981 at main (1f6c2306d3ed). https://bu...

[Michael Catanzaro]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: e9c4d21fe91bfce4b3a37c12624ecef6afa80b85
      https://github.com/WebKit/WebKit/commit/e9c4d21fe91bfce4b3a37c12624ecef6afa80b85
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp

  Log Message:
  -----------
  Cherry-pick 283981 at main (1f6c2306d3ed). https://bugs.webkit.org/show_bug.cgi?id=280003

    REGRESSION(283414 at main): [WPE][GTK] Network process crash when writing to pid socket
    https://bugs.webkit.org/show_bug.cgi?id=280003

    Reviewed by Carlos Garcia Campos.

    If the UI process closes its pid socket connection to the auxiliary
    process before the auxiliary process is able to successfully write the
    pid, the auxiliary process should not crash. That's sort of weird, but
    since 283414 at main it's now expected that this might happen if the
    ProcessLauncher gets destroyed before the process launches.

    In practice, I *suspect* this is actually happening for the
    NetworkProcessProxy's ProcessLauncher, because I don't know how else to
    explain all the network process crashes I am seeing. That's probably a
    bug, and I hesitate to land a change that hides a bug, but it really is
    sometimes expected and shouldn't cause a crash. E.g. If the user presses
    Ctrl+T and then Ctrl+Q in quick succession, the UI process could very
    plausibly quit before a web process launches. Process launching takes a
    couple hundred milliseconds on my computer.

    * Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
    (IPC::sendPIDToPeer):

    Canonical link: https://commits.webkit.org/283981@main

Canonical link: https://commits.webkit.org/282416.122@webkitglib/2.46



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications