[webkit-changes] [WebKit/WebKit] 02558c: [GStreamer][WebRTC] ASSERTs due to access to Media...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02558c78b21cfedd9c2be752d225078a1d142b91
      https://github.com/WebKit/WebKit/commit/02558c78b21cfedd9c2be752d225078a1d142b91
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC] ASSERTs due to access to MediaStreamTrackPrivate::source() from webrtcbin pc thread
https://bugs.webkit.org/show_bug.cgi?id=280119

Reviewed by Xabier Rodriguez-Calvar.

The GStreamerMediaEndpoint::preprocessStats was being called from the webrtcbin pc thread, leading
to asserts in MediaStreamTrackPrivate::source(). This method is now called from the main thread.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::gatherStatsForLogging):
(WebCore::GStreamerMediaEndpoint::preprocessStats):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::GStreamerStatsCollector::getStats):

Canonical link: https://commits.webkit.org/284064@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications