[webkit-changes] [WebKit/WebKit] b5544d: Test runner features are not parsed when parsing a...

[Kimmo Kinnunen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5544dd6df8b54100b6504044f52b66fc9f1d616
      https://github.com/WebKit/WebKit/commit/b5544dd6df8b54100b6504044f52b66fc9f1d616
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-09-23 (Mon, 23 Sep 2024)

  Changed paths:
    M Tools/TestRunnerShared/TestFeatures.cpp
    M Tools/TestRunnerShared/TestFeatures.h
    M Tools/WebKitTestRunner/Options.cpp

  Log Message:
  -----------
  Test runner features are not parsed when parsing additional headers
https://bugs.webkit.org/show_bug.cgi?id=280053
rdar://136352852

Reviewed by Alex Christensen.

run-webkit-tests would support passing the test header feature line
as --additional-header "Feature=true"

However, it was parsed with functions that stored the feature into
WebPreferences. Some features such as runInCrossOriginFrame=true
are stored in test runner features.

Fixes use-case like debugging the WebKitTestRunner directly and passing
the parameters as command line parameters instead of stdin:

```
 DYLD_FRAMEWORK_PATH=$PWD lldb -- ./WebKitTestRunner \
 http://127.0.0.1:8000/root/webgl/webgl-allow-shared-typed-array.html
 --absolutePath $HOME/WebKit/OpenSource/LayoutTests/webgl/webgl-allow-shared-typed-array.html \
 --no-timeout \
 --additional-header runInCrossOriginFrame=true \
 --experimental-feature SiteIsolationEnabled=true \
```

* Tools/TestRunnerShared/TestFeatures.cpp:
(WTR::parseTestHeaderFeature):
(WTR::parseTestHeaderString):
(WTR::parseTestHeader):
(WTR::featureDefaultsFromSelfComparisonHeader):
(WTR::featureFromAdditionalHeaderOption):
(WTR::parseAdditionalHeaderString):
* Tools/TestRunnerShared/TestFeatures.h:
* Tools/WebKitTestRunner/Options.cpp:
(WTR::handleOptionAdditionalHeader):

Canonical link: https://commits.webkit.org/284062@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications