[webkit-changes] [WebKit/WebKit] de71d4: Remove unnecessary uses of reinterpret_cast

[Darin Adler]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: de71d4602041131133097d9fe6dcf91c55a3a298
      https://github.com/WebKit/WebKit/commit/de71d4602041131133097d9fe6dcf91c55a3a298
  Author: Darin Adler <darin at apple.com>
  Date:   2024-09-22 (Sun, 22 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/API/JSStringRefCF.cpp
    M Source/JavaScriptCore/assembler/ProbeStack.h
    M Source/JavaScriptCore/assembler/RISCV64Assembler.h
    M Source/JavaScriptCore/assembler/X86Assembler.h
    M Source/JavaScriptCore/assembler/testmasm.cpp
    M Source/JavaScriptCore/bytecode/CodeBlock.cpp
    M Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp
    M Source/JavaScriptCore/disassembler/X86Disassembler.cpp
    M Source/JavaScriptCore/interpreter/StackVisitor.cpp
    M Source/JavaScriptCore/jit/ExecutableAllocator.cpp
    M Source/JavaScriptCore/jit/ExecutableAllocator.h
    M Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp
    M Source/WTF/wtf/DateMath.cpp
    M Source/WTF/wtf/RobinHoodHashTable.h
    M Source/WTF/wtf/cocoa/NSURLExtras.mm
    M Source/WebCore/Modules/WebGPU/GPUQueue.cpp
    M Source/WebCore/platform/FileHandle.cpp
    M Source/WebCore/platform/graphics/cg/GraphicsContextGLCG.cpp
    M Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.cpp
    M Source/WebCore/platform/network/create-http-header-name-table
    M Source/WebCore/platform/text/mac/TextBoundaries.mm
    M Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm
    M Source/WebKit/Shared/Cocoa/CoreIPCCFURL.mm
    M Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm

  Log Message:
  -----------
  Remove unnecessary uses of reinterpret_cast
https://bugs.webkit.org/show_bug.cgi?id=280155
rdar://136457809

Reviewed by Chris Dumez.

* Source/JavaScriptCore/API/JSStringRefCF.cpp:
(JSStringCopyCFString): Removed unneeded cast.

* Source/JavaScriptCore/assembler/ProbeStack.h:
(JSC::Probe::Page::get): Use static_cast.
(JSC::Probe::Page::set): Ditto.
(JSC::Probe::Page::physicalAddressFor): Ditto.
(JSC::Probe::Stack::get): Ditto.
(JSC::Probe::Stack::set): Ditto.

* Source/JavaScriptCore/assembler/RISCV64Assembler.h:
(JSC::RISCV64Assembler::repatchPointer): Use static_cast.
(JSC::RISCV64Assembler::relinkJump): Ditto.
(JSC::RISCV64Assembler::relinkCall): Ditto.
(JSC::RISCV64Assembler::replaceWithVMHalt): Ditto.
(JSC::RISCV64Assembler::replaceWithJump): Ditto.
(JSC::RISCV64Assembler::revertJumpReplacementToPatch): Ditto.
(JSC::RISCV64Assembler::readCallTarget): Ditto.
(JSC::RISCV64Assembler::cacheFlush): Ditto.
(JSC::RISCV64Assembler::fillNops): Ditto.

* Source/JavaScriptCore/assembler/X86Assembler.h:
(JSC::X86Assembler::isInt3): Use static_cast.
(JSC::X86Assembler::linkJump): Ditto.
(JSC::X86Assembler::linkCall): Ditto.
(JSC::X86Assembler::linkPointer): Ditto.
(JSC::X86Assembler::revertJumpTo_movq_i64r): Ditto.
(JSC::X86Assembler::revertJumpTo_movl_i32r): Ditto.
(JSC::X86Assembler::revertJumpTo_cmpl_ir_force32): Ditto.
(JSC::X86Assembler::revertJumpTo_cmpl_im_force32): Ditto.
(JSC::X86Assembler::fillNops): Ditto.

* Source/JavaScriptCore/assembler/testmasm.cpp:
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack): Use static_cast.
(JSC::testProbeModifiesStackValues): Ditto.

* Source/JavaScriptCore/bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpSource): Use static_cast.

* Source/JavaScriptCore/disassembler/ARM64Disassembler.cpp:
(JSC::tryToDisassemble): Removed unneeded cast.

* Source/JavaScriptCore/disassembler/X86Disassembler.cpp:
(JSC::tryToDisassemble): Removed unneeded cast.

* Source/JavaScriptCore/interpreter/StackVisitor.cpp:
(JSC::StackVisitor::StackVisitor): Use static_cast.

* Source/JavaScriptCore/jit/ExecutableAllocator.cpp:
(JSC::initializeJITPageReservation): Use static_cast.

* Source/JavaScriptCore/jit/ExecutableAllocator.h:
(JSC::performJITMemcpy): Use static_cast.

* Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::evaluate): Use static_cast.

* Source/WTF/wtf/DateMath.cpp:
(WTF::parseInt): Use byteCast.
(WTF::parseLong): Ditto.

* Source/WTF/wtf/RobinHoodHashTable.h:
(WTF::SizePolicy>::deallocateTable): Removed unneeded cast.
(WTF::SizePolicy>::rehash): Ditto.

* Source/WTF/wtf/cocoa/NSURLExtras.mm:
(WTF::isUserVisibleURL): Removed unneeded cast.

* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::imageBytesForSource): Removed unneeded cast.

* Source/WebCore/platform/FileHandle.cpp:
(WebCore::FileHandle::printf): Use byteCast.

* Source/WebCore/platform/graphics/cg/GraphicsContextGLCG.cpp:
(WebCore::GraphicsContextGLImageExtractor::extractImage): Removed uneeded casts.

* Source/WebCore/platform/graphics/cocoa/UnrealizedCoreTextFont.cpp:
(WebCore::appendOpenTypeFeature): Use byteCast.

* Source/WebCore/platform/network/create-http-header-name-table:
(WebCore::findHTTPHeaderName): Use byteCast.

* Source/WebCore/platform/text/mac/TextBoundaries.mm:
(WebCore::tokenizerForString): Use byteCast.

* Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
(WebKit::AuthenticationManager::initializeConnection): Use static_cast.

* Source/WebKit/Shared/Cocoa/CoreIPCCFURL.mm:
(WebKit::CoreIPCCFURL::createWithBaseURLAndBytes): Removed uneeded cast.
Also use bridge_cast.

* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel _chooseFiles:displayString:iconImage:]): Use static_cast.

Canonical link: https://commits.webkit.org/284050@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications