[webkit-changes] [WebKit/WebKit] cdd75c: 1Password popup size ignoring width and height set...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdd75cea26ceefb3b641964c07c3ea93e7ec53bb
      https://github.com/WebKit/WebKit/commit/cdd75cea26ceefb3b641964c07c3ea93e7ec53bb
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm

  Log Message:
  -----------
  1Password popup size ignoring width and height set on body on iPadOS 18.
https://webkit.org/b/280092
rdar://135439066

Reviewed by Brian Weinstein.

We were mistakenly factoring `boundsSize` into the min-width and min-height calculations, causing the
1Password popover to display at 375pt instead of the intended 600pt. This change corrects that
behavior to align with Safari 17's size handling.

Tested with 1Password, CardPointers, Grammarly, and Noir — all now render as expected.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(-[_WKWebExtensionActionViewController _updatePopoverContentSize]): Remove `boundsSize`.

Canonical link: https://commits.webkit.org/284020@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications