[webkit-changes] [WebKit/WebKit] dc6108: [Writing Tools] Form accessory view shows above pa...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dc6108c72c6aad4d22185d371c3d78d6ec85df40
      https://github.com/WebKit/WebKit/commit/dc6108c72c6aad4d22185d371c3d78d6ec85df40
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [Writing Tools] Form accessory view shows above panel when invoked on editable content in Safari
https://bugs.webkit.org/show_bug.cgi?id=280028
rdar://136177733

Reviewed by Richard Robinson.

Following recent UIKit changes it is the responsibility of the Writing Tools
client to ensure the input accessory view is hidden when the panel is visible.

This is achieved by keeping track of panel visibility using methods on the
`UITextInput` protocol, and returning a `nil` `inputAccessoryView` as needed.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView requiresAccessoryView]):
(-[WKContentView willPresentWritingTools]):

UIKit currently has a bug where `reloadInputViews` has does not update the
input accessory view when the Writing Tools panel is visible.

Consequently, workaround the bug for now by manually showing/hiding WebKit's
accessory view. This will not fix custom views, but WebKit should not be
modifying views it doesn't own.

(-[WKContentView didDismissWritingTools]):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, PanelHidesInputAccessoryView)):

Canonical link: https://commits.webkit.org/284005@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications