[webkit-changes] [WebKit/WebKit] c8a687: Adopt GB18030-2022 into GBK more fully

Anne van Kesteren noreply at github.com
Fri Sep 20 09:07:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c8a687829285dd572528fca4fd8aa9abf4acff09
      https://github.com/WebKit/WebKit/commit/c8a687829285dd572528fca4fd8aa9abf4acff09
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-09-20 (Fri, 20 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-decoder.any.js
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-encoder-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-encoder.html
    M Source/WebCore/PAL/pal/text/TextCodecCJK.cpp

  Log Message:
  -----------
  Adopt GB18030-2022 into GBK more fully
https://bugs.webkit.org/show_bug.cgi?id=279903

Reviewed by Alex Christensen.

For GBK and gb18030 we have used the same backing table for quite a
while now. This backing table was updated to account for GB18030-2022
at some point and this impacted GBK as well.

However, the encoder side table was kept disabled for GBK, despite it
actually allowing GBK to be more compatible with its former self.

https://github.com/whatwg/encoding/pull/336 now standardizes the
behavior that GBK and gb18030 are to remain aligned in these matters
and this change implements that.

The corresponding tests are from this PR:
https://github.com/web-platform-tests/wpt/pull/48240

* LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-decoder.any.js:
* LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-encoder-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gbk/gbk-encoder.html:
* Source/WebCore/PAL/pal/text/TextCodecCJK.cpp:
(PAL::gb18030AsymmetricEncode):
(PAL::gbEncodeShared):

Canonical link: https://commits.webkit.org/283987@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list