[webkit-changes] [WebKit/WebKit] 5cdfc9: REGRESSION(283879 at main): When automatically resize...

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5cdfc9f8b7eaa7841a8d89c15dc4abe3b7d3fbfc
      https://github.com/WebKit/WebKit/commit/5cdfc9f8b7eaa7841a8d89c15dc4abe3b7d3fbfc
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  REGRESSION(283879 at main): When automatically resize is enabled, PDF unexpectedly scrolls when window is resized
https://bugs.webkit.org/show_bug.cgi?id=280018
rdar://136311543

Reviewed by Aditya Keerthi.

It's wrong for us to ignore anchoring info if the document layout update
is not a no-op, which was a behavior change we introduced in 283487 at main.

Instead, we backtrack our behavior into always respecting anchoring info
if present, and then introduce a slight modification where we recompute
the anchoring info if the document layout changes entirely on an update,
as would be the case when unlocking some encrypted PDF documents.

This modification is required so that we don't restore to a stale anchor
after unlocking some problematic encrypted files, while also not
throwing away anchoring information on minor layout changes.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDocumentLayout.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateLayout):

Canonical link: https://commits.webkit.org/283960@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications