[webkit-changes] [WebKit/WebKit] 8999c6: Remove LegacyReceiver IPC message dispatch mode

Kimmo Kinnunen noreply at github.com
Thu Sep 19 09:44:14 PDT 2024 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8999c686ffa511456c62e551a49e36e774c05d7d
      https://github.com/WebKit/WebKit/commit/8999c686ffa511456c62e551a49e36e774c05d7d
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.h
    M Source/WebKit/NetworkProcess/NetworkResourceLoader.messages.in
    M Source/WebKit/Platform/IPC/Connection.cpp
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in
    M Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebProcessProxy.messages.in
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in
    M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
    M Source/WebKit/WebProcess/Network/NetworkProcessConnection.h
    M Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in
    M Source/WebKit/WebProcess/Network/WebResourceLoader.h
    M Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKit/mac/WebKit2.order

  Log Message:
  -----------
  Remove LegacyReceiver IPC message dispatch mode
https://bugs.webkit.org/show_bug.cgi?id=279713
rdar://136008632

Reviewed by Alex Christensen.

Removes the use of LegacyReceiver. It complicates the message dispatch.
It's simpler if all receivers follow a bit more uniform conventions.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::dispatchMessage):
(WebKit::NetworkConnectionToWebProcess::dispatchSyncMessage):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage): Deleted.
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::sharedPreferencesForWebProcess const): Deleted.
(WebKit::NetworkConnectionToWebProcess::updateSharedPreferencesForWebProcess): Deleted.
(WebKit::NetworkConnectionToWebProcess::sessionID const): Deleted.
(WebKit::NetworkConnectionToWebProcess::connection): Deleted.
(WebKit::NetworkConnectionToWebProcess::protectedConnection): Deleted.
(WebKit::NetworkConnectionToWebProcess::networkProcess): Deleted.
(WebKit::NetworkConnectionToWebProcess::isWebTransportEnabled const): Deleted.
(WebKit::NetworkConnectionToWebProcess::usesSingleWebProcess const): Deleted.
(WebKit::NetworkConnectionToWebProcess::blobFileAccessEnforcementEnabled const): Deleted.
(WebKit::NetworkConnectionToWebProcess::captureExtraNetworkLoadMetricsEnabled const): Deleted.
(WebKit::NetworkConnectionToWebProcess::getNetworkLoadInformationResponse): Deleted.
(WebKit::NetworkConnectionToWebProcess::getNetworkLoadIntermediateInformation): Deleted.
(WebKit::NetworkConnectionToWebProcess::takeNetworkLoadInformationMetrics): Deleted.
(WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformation): Deleted.
(WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics): Deleted.
(WebKit::NetworkConnectionToWebProcess::removeNetworkLoadInformation): Deleted.
(WebKit::NetworkConnectionToWebProcess::webProcessIdentifier const): Deleted.
(WebKit::NetworkConnectionToWebProcess::schemeRegistry): Deleted.
(WebKit::NetworkConnectionToWebProcess::originAccessPatterns): Deleted.
(WebKit::NetworkConnectionToWebProcess::mdnsRegister): Deleted.
(WebKit::NetworkConnectionToWebProcess::swContextConnection): Deleted.
(WebKit::NetworkConnectionToWebProcess::startDownload): Deleted.
(WebKit::NetworkConnectionToWebProcess::allowTestOnlyIPC const): Deleted.
(WebKit::NetworkConnectionToWebProcess::isLoginStatusAPIRequiresWebAuthnEnabled const): Deleted.
(WebKit::NetworkConnectionToWebProcess::ResourceNetworkActivityTracker::ResourceNetworkActivityTracker): Deleted.
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.h:
* Source/WebKit/NetworkProcess/NetworkResourceLoader.messages.in:
* Source/WebKit/Scripts/webkit/messages.py:
(generate_message_handler):
* Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiver.messages.in:
* Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
(WebKit::TestWithLegacyReceiver::didReceiveMessage):
(WebKit::TestWithLegacyReceiver::didReceiveSyncMessage):
(WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage): Deleted.
(WebKit::TestWithLegacyReceiver::didReceiveSyncTestWithLegacyReceiverMessage): Deleted.
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage): Deleted.
(WebKit::NetworkProcessProxy::didReceiveSyncMessage): Deleted.
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::dispatchMessage):
(WebKit::WebProcessProxy::dispatchSyncMessage):
(WebKit::WebProcessProxy::didReceiveMessage): Deleted.
(WebKit::WebProcessProxy::didReceiveSyncMessage): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::suspendedPageCount const): Deleted.
(WebKit::WebProcessProxy::sharedPreferencesForWebProcess const): Deleted.
(WebKit::WebProcessProxy::isMatchingRegistrableDomain const): Deleted.
(WebKit::WebProcessProxy::registrableDomain const): Deleted.
(WebKit::WebProcessProxy::optionalRegistrableDomain const): Deleted.
(WebKit::WebProcessProxy::isInProcessCache const): Deleted.
(WebKit::WebProcessProxy::websiteDataStore const): Deleted.
(WebKit::WebProcessProxy::pageCount const): Deleted.
(WebKit::WebProcessProxy::provisionalPageCount const): Deleted.
(WebKit::WebProcessProxy::visiblePageCount const): Deleted.
(WebKit::WebProcessProxy::isRunningServiceWorkers const): Deleted.
(WebKit::WebProcessProxy::isStandaloneServiceWorkerProcess const): Deleted.
(WebKit::WebProcessProxy::isRunningSharedWorkers const): Deleted.
(WebKit::WebProcessProxy::isStandaloneSharedWorkerProcess const): Deleted.
(WebKit::WebProcessProxy::isRunningWorkers const): Deleted.
(WebKit::WebProcessProxy::willAcquireUniversalFileReadSandboxExtension): Deleted.
(WebKit::WebProcessProxy::isSuddenTerminationEnabled): Deleted.
(WebKit::WebProcessProxy::memoryPressureStatusChanged): Deleted.
(WebKit::WebProcessProxy::isUnderMemoryPressure const): Deleted.
(WebKit::WebProcessProxy::didCommitProvisionalLoad): Deleted.
(WebKit::WebProcessProxy::hasCommittedAnyProvisionalLoads const): Deleted.
(WebKit::WebProcessProxy::didCommitMeaningfulProvisionalLoad): Deleted.
(WebKit::WebProcessProxy::hasCommittedAnyMeaningfulProvisionalLoads const): Deleted.
(WebKit::WebProcessProxy::isPrewarmed const): Deleted.
(WebKit::WebProcessProxy::displayLinkClient): Deleted.
(WebKit::WebProcessProxy::shutdownPreventingScope): Deleted.
(WebKit::WebProcessProxy::hasVideoCaptureExtension const): Deleted.
(WebKit::WebProcessProxy::grantVideoCaptureExtension): Deleted.
(WebKit::WebProcessProxy::revokeVideoCaptureExtension): Deleted.
(WebKit::WebProcessProxy::hasAudioCaptureExtension const): Deleted.
(WebKit::WebProcessProxy::grantAudioCaptureExtension): Deleted.
(WebKit::WebProcessProxy::revokeAudioCaptureExtension): Deleted.
(WebKit::WebProcessProxy::hasServiceWorkerPageProxy): Deleted.
(WebKit::WebProcessProxy::userMediaCaptureManagerProxy): Deleted.
(WebKit::WebProcessProxy::hasNetworkExtensionSandboxAccess const): Deleted.
(WebKit::WebProcessProxy::markHasNetworkExtensionSandboxAccess): Deleted.
(WebKit::WebProcessProxy::audioSessionRoutingArbitrator): Deleted.
(WebKit::WebProcessProxy::ignoreInvalidMessageForTesting const): Deleted.
(WebKit::WebProcessProxy::allowTestOnlyIPC const): Deleted.
(WebKit::WebProcessProxy::setAllowTestOnlyIPC): Deleted.
(WebKit::WebProcessProxy::crossOriginMode const): Deleted.
(WebKit::WebProcessProxy::lockdownMode const): Deleted.
(WebKit::WebProcessProxy::isConnectedToHardwareConsole const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::WeakOrStrongPtr): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::setIsWeak): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::get const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::operator-> const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::operator* const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::operator bool const): Deleted.
(WebKit::WebProcessProxy::WeakOrStrongPtr::updateStrongReference): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::didReceiveMessage): Deleted.
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.messages.in:
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::dispatchMessage):
(WebKit::NetworkProcessConnection::dispatchSyncMessage):
(WebKit::NetworkProcessConnection::didReceiveMessage): Deleted.
(WebKit::NetworkProcessConnection::didReceiveSyncMessage): Deleted.
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.h:
(WebKit::NetworkProcessConnection::create): Deleted.
(WebKit::NetworkProcessConnection::protectedConnection): Deleted.
(WebKit::NetworkProcessConnection::connection): Deleted.
(WebKit::NetworkProcessConnection::existingIDBConnectionToServer const): Deleted.
(WebKit::NetworkProcessConnection::setNetworkProcessAuditToken): Deleted.
(WebKit::NetworkProcessConnection::networkProcessAuditToken const): Deleted.
(WebKit::NetworkProcessConnection::cookieAcceptPolicy const): Deleted.
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.messages.in:
* Source/WebKit/WebProcess/Network/WebResourceLoader.h:
* Source/WebKit/WebProcess/Network/WebResourceLoader.messages.in:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dispatchMessage):
(WebKit::WebPage::didReceiveMessage): Deleted.
(WebKit::WebPage::didReceiveSyncMessage): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::corePage const): Deleted.
(WebKit::WebPage::identifier const): Deleted.
(WebKit::WebPage::size const): Deleted.
(WebKit::WebPage::drawingArea const): Deleted.
(WebKit::WebPage::pageGroup const): Deleted.
(WebKit::WebPage::isInspectorPage): Deleted.
(WebKit::WebPage::allowsMediaDocumentInlinePlayback const): Deleted.
(WebKit::WebPage::hasCustomUserAgent const): Deleted.
(WebKit::WebPage::overrideContentSecurityPolicy const): Deleted.
(WebKit::WebPage::isInRedo const): Deleted.
(WebKit::WebPage::setIsInRedo): Deleted.
(WebKit::WebPage::activeOpenPanelResultListener const): Deleted.
(WebKit::WebPage::injectedBundleContextMenuClient): Deleted.
(WebKit::WebPage::injectedBundleEditorClient): Deleted.
(WebKit::WebPage::injectedBundleFormClient): Deleted.
(WebKit::WebPage::injectedBundleLoaderClient): Deleted.
(WebKit::WebPage::injectedBundleResourceLoadClient): Deleted.
(WebKit::WebPage::injectedBundleUIClient): Deleted.
(WebKit::WebPage::injectedBundleFullScreenClient): Deleted.
(WebKit::WebPage::mainWebFrame const): Deleted.
(WebKit::WebPage::useFixedLayout const): Deleted.
(WebKit::WebPage::setUnderlayColor): Deleted.
(WebKit::WebPage::underlayColor const): Deleted.
(WebKit::WebPage::activityState const): Deleted.
(WebKit::WebPage::layerHostingMode const): Deleted.
(WebKit::WebPage::windowFrameInScreenCoordinates const): Deleted.
(WebKit::WebPage::windowFrameInUnflippedScreenCoordinates const): Deleted.
(WebKit::WebPage::viewFrameInWindowCoordinates const): Deleted.
(WebKit::WebPage::hasCachedWindowFrame const): Deleted.
(WebKit::WebPage::findController): Deleted.
(WebKit::WebPage::foundTextRangeController): Deleted.
(WebKit::WebPage::geolocationPermissionRequestManager): Deleted.
(WebKit::WebPage::userMediaPermissionRequestManager): Deleted.
(WebKit::WebPage::mediaKeySystemPermissionRequestManager): Deleted.
(WebKit::WebPage::shouldRevealCurrentSelectionAfterInsertion const): Deleted.
(WebKit::WebPage::deviceOrientation const): Deleted.
(WebKit::WebPage::screenIsBeingCaptured const): Deleted.
(WebKit::WebPage::hasStablePageScaleFactor const): Deleted.
(WebKit::WebPage::setIsShowingInputViewForFocusedElement): Deleted.
(WebKit::WebPage::isShowingInputViewForFocusedElement const): Deleted.
(WebKit::WebPage::forceAlwaysUserScalable const): Deleted.
(WebKit::WebPage::willChangeSelectionForAccessibility): Deleted.
(WebKit::WebPage::didChangeSelectionForAccessibility): Deleted.
(WebKit::WebPage::markLayersVolatile): Deleted.
(WebKit::WebPage::sandboxExtensionTracker): Deleted.
(WebKit::WebPage::accessibilityPosition const): Deleted.
(WebKit::WebPage::isStoppingLoadingDueToProcessSwap const): Deleted.
(WebKit::WebPage::willStartDrag): Deleted.
(WebKit::WebPage::allowedDragSourceActions const): Deleted.
(WebKit::WebPage::beginPrintingDuringDOMPrintOperation): Deleted.
(WebKit::WebPage::endPrinting): Deleted.
(WebKit::WebPage::endPrintingDuringDOMPrintOperation): Deleted.
(WebKit::WebPage::computePagesForPrintingDuringDOMPrintOperation): Deleted.
(WebKit::WebPage::drawRectToImageDuringDOMPrintOperation): Deleted.
(WebKit::WebPage::drawPagesToPDFDuringDOMPrintOperation): Deleted.
(WebKit::WebPage::drawPagesForPrintingDuringDOMPrintOperation): Deleted.
(WebKit::WebPage::canRunBeforeUnloadConfirmPanel const): Deleted.
(WebKit::WebPage::setCanRunBeforeUnloadConfirmPanel): Deleted.
(WebKit::WebPage::canRunModal const): Deleted.
(WebKit::WebPage::setCanRunModal): Deleted.
(WebKit::WebPage::scaleWasSetByUIProcess const): Deleted.
(WebKit::WebPage::hardwareKeyboardIsAttached const): Deleted.
(WebKit::WebPage::canShowWhileLocked const): Deleted.
(WebKit::WebPage::viewportConfiguration const): Deleted.
(WebKit::WebPage::setUseTestingViewportConfiguration): Deleted.
(WebKit::WebPage::isUsingTestingViewportConfiguration const): Deleted.
(WebKit::WebPage::pdfPluginEnabled const): Deleted.
(WebKit::WebPage::setPDFPluginEnabled): Deleted.
(WebKit::WebPage::selectionFlippingEnabled const): Deleted.
(WebKit::WebPage::setSelectionFlippingEnabled): Deleted.
(WebKit::WebPage::dataDetectionReferenceDate const): Deleted.
(WebKit::WebPage::mainFrameIsScrollable const): Deleted.
(WebKit::WebPage::alwaysShowsHorizontalScroller const): Deleted.
(WebKit::WebPage::alwaysShowsVerticalScroller const): Deleted.
(WebKit::WebPage::minimumSizeForAutoLayout const): Deleted.
(WebKit::WebPage::sizeToContentAutoSizeMaximumSize const): Deleted.
(WebKit::WebPage::autoSizingShouldExpandToViewHeight): Deleted.
(WebKit::WebPage::viewportSizeForCSSViewportUnits const): Deleted.
(WebKit::WebPage::shouldExtendIncrementalRenderingSuppression): Deleted.
(WebKit::WebPage::scrollPinningBehavior): Deleted.
(WebKit::WebPage::scrollbarOverlayStyle): Deleted.
(WebKit::WebPage::setMainFrameProgressCompleted): Deleted.
(WebKit::WebPage::shouldDispatchFakeMouseMoveEvents const): Deleted.
(WebKit::WebPage::loadCommitTime const): Deleted.
(WebKit::WebPage::cpuLimit const): Deleted.
(WebKit::WebPage::themeColorChanged): Deleted.
(WebKit::WebPage::pageExtendedBackgroundColorDidChange): Deleted.
(WebKit::WebPage::sampledPageTopColorChanged): Deleted.
(WebKit::WebPage::loadedSubresourceDomains const): Deleted.
(WebKit::WebPage::hostFileDescriptor const): Deleted.
(WebKit::WebPage::webExtensionControllerProxy const): Deleted.
(WebKit::WebPage::userInterfaceLayoutDirection const): Deleted.
(WebKit::WebPage::isSuspended const): Deleted.
(WebKit::WebPage::sendSyncWithDelayedReply): Deleted.
(WebKit::WebPage::backgroundColor const): Deleted.
(WebKit::WebPage::textCheckingController): Deleted.
(WebKit::WebPage::webPageProxyIdentifier const): Deleted.
(WebKit::WebPage::userIsInteracting const): Deleted.
(WebKit::WebPage::setUserIsInteracting): Deleted.
(WebKit::WebPage::overriddenMediaType const): Deleted.
(WebKit::WebPage::ipcTestingAPIEnabled const): Deleted.
(WebKit::WebPage::webPageProxyID const): Deleted.
(WebKit::WebPage::visitedLinkTableID const): Deleted.
(WebKit::WebPage::allowsContentJavaScriptFromMostRecentNavigation const): Deleted.
(WebKit::WebPage::setAllowsContentJavaScriptFromMostRecentNavigation): Deleted.
(WebKit::WebPage::needsInAppBrowserPrivacyQuirks): Deleted.
(WebKit::WebPage::applyLinkDecorationFiltering): Deleted.
(WebKit::WebPage::requestTextRecognition): Deleted.
(WebKit::WebPage::nativeWindowHandle): Deleted.
(WebKit::WebPage::highlightIsNewGroup const): Deleted.
(WebKit::WebPage::highlightRequestOriginatedInApp const): Deleted.
(WebKit::WebPage::appHighlightsVisiblility const): Deleted.
(WebKit::WebPage::setLastNavigationWasAppInitiated): Deleted.
(WebKit::WebPage::baseViewportLayoutSizeScaleFactor const): Deleted.
(WebKit::WebPage::useARKitForModel const): Deleted.
(WebKit::WebPage::useSceneKitForModel const): Deleted.
(WebKit::WebPage::setSkipDecidePolicyForResponseIfPossible): Deleted.
(WebKit::WebPage::isInStableState const): Deleted.
(WebKit::WebPage::preferredBufferFormats const): Deleted.
(WebKit::WebPage::mediaEnvironment const): Deleted.
(WebKit::WebPage::addTextAnimationForAnimationID): Deleted.
(WebKit::WebPage::layerTreeFreezeReasons const): Deleted.
(WebKit::WebPage::preferencesDidChangeDuringDOMPrintOperation): Deleted.
(WebKit::WebPage::parentProcessHasServiceWorkerEntitlement const): Deleted.
(WebKit::WebPage::disableServiceWorkerEntitlement): Deleted.
(WebKit::WebPage::clearServiceWorkerEntitlementOverride): Deleted.
(WebKit::WebPage::setShouldDispatchFakeMouseMoveEvents): Deleted.
(WebKit::WebPage::PrintContextAccessScope::PrintContextAccessScope): Deleted.
(WebKit::WebPage::PrintContextAccessScope::~PrintContextAccessScope): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/mac/WebKit2.order:

Canonical link: https://commits.webkit.org/283924@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications

More information about the webkit-changes mailing list