[webkit-changes] [WebKit/WebKit] c4e162: ASSERTION FAILED: !reg.isConstant() caused by dest...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c4e162760b3e7f52c3bd971756f9c594ce6873ae
      https://github.com/WebKit/WebKit/commit/c4e162760b3e7f52c3bd971756f9c594ce6873ae
  Author: Alexey Shvayka <ashvayka at apple.com>
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
    A JSTests/stress/regress-279863.js
    M Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

  Log Message:
  -----------
  ASSERTION FAILED: !reg.isConstant() caused by destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=279863
<rdar://136233004>

Reviewed by Yusuke Suzuki and Mark Lam.

RETURN macro of CommonSlowPaths.cpp accesses destination register via GET macro,
which asserts it to be non-constant. This change fixes the failing isConstant()
assertion for OpToPropertyKeyOrNumber emitted in ObjectPatternNode::bindValue()
by using temporary register if rest element is absent, while carefully preserving
existing logic in case of m_containsRestElement.

* JSTests/stress/regress-279863.js: Added.
* Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:
(JSC::ObjectPatternNode::bindValue const):

Canonical link: https://commits.webkit.org/283922@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications