[webkit-changes] [WebKit/WebKit] 7a790b: [GTK][WPE][Skia] Replace SkiaAcceleratedBufferPool...

[Nikolas Zimmermann]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7a790bf39428c4a02fcac4d96a7998855d3b5a35
      https://github.com/WebKit/WebKit/commit/7a790bf39428c4a02fcac4d96a7998855d3b5a35
  Author: Nikolas Zimmermann <nzimmermann at igalia.com>
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/Skia.cmake
    M Source/WebCore/platform/SourcesSkia.txt
    M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp
    M Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h
    R Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp
    R Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h
    M Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h
    M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h

  Log Message:
  -----------
  [GTK][WPE][Skia] Replace SkiaAcceleratedBufferPool by BitmapTexturePool
https://bugs.webkit.org/show_bug.cgi?id=279882

Reviewed by Carlos Garcia Campos.

We don't need SkiaAcceleratedBufferPool, and keep alive
Nicosia::AcceleratedBuffer objects in a pool. Switch to
BitmapTexturePool for GL texture allocation, and let AcceleratedBuffer
receive a BitmapTexture object instead of a SkSurface.

This simplifies the code and lets us re-use the facilities
BitmapTexturePool has to limit resource consumption, etc.

Covered by existing tests.

* Source/WebCore/platform/Skia.cmake:
* Source/WebCore/platform/SourcesSkia.txt:
* Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:
(Nicosia::Buffer::canvas):
(Nicosia::UnacceleratedBuffer::UnacceleratedBuffer):
(Nicosia::UnacceleratedBuffer::tryEnsureSurface):
(Nicosia::AcceleratedBuffer::create):
(Nicosia::AcceleratedBuffer::AcceleratedBuffer):
(Nicosia::AcceleratedBuffer::~AcceleratedBuffer):
(Nicosia::AcceleratedBuffer::size const):
(Nicosia::AcceleratedBuffer::tryEnsureSurface):
(Nicosia::AcceleratedBuffer::completePainting):
(Nicosia::AcceleratedBuffer::beginPainting): Deleted.
* Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.h:
(Nicosia::Buffer::platformWaitUntilPaintingComplete): Deleted.
(Nicosia::Buffer::surface const): Deleted.
* Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp: Removed.
* Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h: Removed.
* Source/WebCore/platform/graphics/texmap/BitmapTexturePool.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStoreTile::swapBuffers):
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
* Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp:
(WebCore::CoordinatedGraphicsLayer::paintTile):
(WebCore::CoordinatedGraphicsLayer::paintImage):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::CompositingCoordinator):
(WebKit::CompositingCoordinator::invalidate):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

Canonical link: https://commits.webkit.org/283913@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications