[webkit-changes] [WebKit/WebKit] 5364cc: Do recursive update for commit when frame loading ...

[ziransun]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5364cc17ccbf86a58357b9d7a3d01655746fd170
      https://github.com/WebKit/WebKit/commit/5364cc17ccbf86a58357b9d7a3d01655746fd170
  Author: Ziran Sun <zsun at igalia.com>
  Date:   2024-09-19 (Thu, 19 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/loader/HistoryController.cpp
    M Source/WebCore/loader/HistoryController.h

  Log Message:
  -----------
  Do recursive update for commit when frame loading is complete.
https://bugs.webkit.org/show_bug.cgi?id=256976

Reviewed by Chris Dumez.

In updateForCommit, we call recursiveUpdateForCommit to tell all
other frames to commit their provisional items and restore scroll
positions. This should only be called when the frame loading is complete.
This fixes an assertion failure for a couple of test cases with the combination
of cross document traversal and same document navigation.

* LayoutTests/TestExpectations:
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::HistoryController::updateForCommit):
* Source/WebCore/loader/HistoryController.h:

Canonical link: https://commits.webkit.org/283904@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications