[webkit-changes] [WebKit/WebKit] e22cd1: [EWS] pre-existing failures in macOS - ASSERTION F...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e22cd14e006661575f4314395eb67ef2e5a6276d
      https://github.com/WebKit/WebKit/commit/e22cd14e006661575f4314395eb67ef2e5a6276d
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  [EWS] pre-existing failures in macOS - ASSERTION FAILED: didRemove in Source/WebKit/UIProcess/WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=279917
rdar://136245139

Reviewed by Ryosuke Niwa.

One of the things I said in 283819 at main applies only with site isolation on.
With site isolation off we do get the WebPageProxy::didDestroyFrame message for
each destroyed frame and we should not clear the m_framesWithSubresourceLoadingForPageLoadTiming
because we will receive a message saying to remove each frame, and we want to continue
to assert that those removals each correspond with an addition.

* LayoutTests/TestExpectations:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):

Canonical link: https://commits.webkit.org/283887@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications