[webkit-changes] [WebKit/WebKit] cf950f: Cloudflare Captcha does not render under site isol...

[mattwoodrow]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cf950ff77fd741c2320824ed6f8720ff54cf9edb
      https://github.com/WebKit/WebKit/commit/cf950ff77fd741c2320824ed6f8720ff54cf9edb
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
    A LayoutTests/http/tests/site-isolation/remote-frame-loaded-while-hidden-expected.html
    A LayoutTests/http/tests/site-isolation/remote-frame-loaded-while-hidden.html
    M Source/WebCore/rendering/RenderWidget.cpp

  Log Message:
  -----------
  Cloudflare Captcha does not render under site isolation.
https://bugs.webkit.org/show_bug.cgi?id=279803
<rdar://136116291>

Reviewed by Alex Christensen.

https://app.dashlane.com never displays the captcha with site-isolation enabled.

The issue is that RenderWidget::setWidget doesn't get called until after
::requiresLayers has been evaluated.

Setting a new widget can affect the result of requiresLayer, so we need to
invalidate style so that it gets checked again.

* LayoutTests/http/tests/site-isolation/remote-frame-loaded-while-hidden-expected.html: Added.
* LayoutTests/http/tests/site-isolation/remote-frame-loaded-while-hidden.html: Added.
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):

Canonical link: https://commits.webkit.org/283881@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications