[webkit-changes] [WebKit/WebKit] 5a9ffa: Remove SVGLengthContext's viewport for performance

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a9ffa94d048a37908ed8bbb6c0694b45feacda1
      https://github.com/WebKit/WebKit/commit/5a9ffa94d048a37908ed8bbb6c0694b45feacda1
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
    M LayoutTests/platform/glib/svg/batik/text/textEffect3-expected.txt
    M LayoutTests/platform/ios/svg/batik/text/textEffect3-expected.txt
    M LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt
    M LayoutTests/svg/filters/feMerge-wrong-input-expected.txt
    M LayoutTests/svg/filters/feMerge-wrong-input.svg
    M Source/WebCore/svg/SVGLengthContext.cpp
    M Source/WebCore/svg/SVGLengthContext.h

  Log Message:
  -----------
  Remove SVGLengthContext's viewport for performance

https://bugs.webkit.org/show_bug.cgi?id=279716
rdar://136009811

Reviewed by Nikolas Zimmermann and Simon Fraser.

Merge: https://chromium.googlesource.com/chromium/src.git/+/cf8a467f2e89d9e9dd5924750b782dd3724935c0

This patch removes m_overriddenViewport from SVGLengthContext and
moves all code into the only user - SVGLengthContext::resolveRectangle.
This was possible because resolveRectangle was the only callsite to
use a viewport.

* Source/WebCore/svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::resolveRectangle):
(WebCore::SVGLengthContext::convertValueToUserUnits const):
(WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits const):
(WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits):
(WebCore::SVGLengthContext::viewportSize const):
(WebCore::SVGLengthContext::computeViewportSize const):
* Source/WebCore/svg/SVGLengthContext.h:
* LayoutTests/platform/glib/svg/batik/text/textEffect3-expected.txt:
* LayoutTests/platform/ios/svg/batik/text/textEffect3-expected.txt:
* LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt:
* LayoutTests/svg/filters/feMerge-wrong-input-expected.txt:
* LayoutTests/svg/filters/feMerge-wrong-input.svg:

Canonical link: https://commits.webkit.org/283877@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications