[webkit-changes] [WebKit/WebKit] ea0e81: [Part 5] All numeric CSSPrimitiveValue resolvers n...

[Sam Weinig]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ea0e8115cda32876124dc327f488b465e7041b0d
      https://github.com/WebKit/WebKit/commit/ea0e8115cda32876124dc327f488b465e7041b0d
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/animations/font-style-interpolation-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-invalid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-valid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/variations/font-style-parsing-expected.txt
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/css/CSSFontFace.cpp
    M Source/WebCore/css/FontSelectionValueInlines.h
    M Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h
    M Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
    M Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.cpp
    M Source/WebCore/style/StyleBuilderConverter.h
    M Source/WebCore/style/StyleBuilderCustom.h
    A Source/WebCore/style/StyleResolveForFont.cpp
    A Source/WebCore/style/StyleResolveForFont.h
    R Source/WebCore/style/StyleResolveForFontRaw.cpp
    R Source/WebCore/style/StyleResolveForFontRaw.h

  Log Message:
  -----------
  [Part 5] All numeric CSSPrimitiveValue resolvers need to take CSSToLengthConversionData: font
https://bugs.webkit.org/show_bug.cgi?id=279677

Reviewed by Antti Koivisto and Darin Adler.

Refactors all font related style building into StyleResolveForFont.h/cpp
with "Deprecated" overloads of resolvers that don't take conversion data
to make it abundantly clear they won't work correctly in all cases.

Updates Style::BuilderConverter to call the new resolvers, ensuring that
all the converter functions now take Style::BuilderState so they have
access to the conversion data / style data.

Fixes a small issue with font-weight computed value serialization by
ensuring that "oblique" gets serialized for computed value even if
the angle is 0 (previously we would have serialized this as "normal").

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-size-adjust-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-stretch-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-style-valid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-weight-valid.html:
    - Update tests with cases for calc() and calc() using relative length units.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
    - Update for renamed file.
* Source/WebCore/css/CSSFontFace.cpp:
* Source/WebCore/css/FontSelectionValueInlines.h:
* Source/WebCore/css/parser/CSSPropertyParserConsumer+Font.h:
* Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:
* Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.cpp:
* Source/WebCore/style/StyleBuilderConverter.h:
* Source/WebCore/style/StyleBuilderCustom.h:
* Source/WebCore/style/StyleResolveForFont.cpp: Renamed from Source/WebCore/style/StyleResolveForFontRaw.cpp.
* Source/WebCore/style/StyleResolveForFont.h: Renamed from Source/WebCore/style/StyleResolveForFontRaw.h.

Canonical link: https://commits.webkit.org/283851@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications