[webkit-changes] [WebKit/WebKit] 61cf3c: [GStreamer][MSE] Playbin3's "element-setup" isn't ...

[Carlos Bentzen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61cf3c8e032af32f397fad34ff5599d8291e8b30
      https://github.com/WebKit/WebKit/commit/61cf3c8e032af32f397fad34ff5599d8291e8b30
  Author: Carlos Bentzen <cadubentzen at igalia.com>
  Date:   2024-09-18 (Wed, 18 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer][MSE] Playbin3's "element-setup" isn't called for uridecodebin3
https://bugs.webkit.org/show_bug.cgi?id=279820

Reviewed by Philippe Normand.

Since GStreamer 1.22, playbin3 creates uridecodebin3 in its _init() function.
This is before the "element-setup" signal can be configured.

Not getting the signal for uridecodebin3 means we weren't setting "buffer-size"
on uridecodebin3, and not calling the platform quirks for uridecodebin3.

Fix this by explicitly getting the uridecodebin3 and call configureElement on
it if we are on GStreamer >= 1.22.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

Canonical link: https://commits.webkit.org/283830@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications