[webkit-changes] [WebKit/WebKit] bc74bc: [IsDeprecatedWeakRefSmartPointerException] Pending...

[geoffreygaren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bc74bcf9e05d4dd52dc9a93dc0414acf8df0d748
      https://github.com/WebKit/WebKit/commit/bc74bcf9e05d4dd52dc9a93dc0414acf8df0d748
  Author: Geoffrey Garen <ggaren at apple.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    M Source/WTF/WTF.xcodeproj/project.pbxproj
    M Source/WTF/wtf/CMakeLists.txt
    A Source/WTF/wtf/RefCountedAndCanMakeWeakPtr.h
    M Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp
    M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
    M Source/WebKit/NetworkProcess/Downloads/PendingDownload.h

  Log Message:
  -----------
  [IsDeprecatedWeakRefSmartPointerException] PendingDownload should not be a smart pointer exception
https://bugs.webkit.org/show_bug.cgi?id=279796
rdar://136113361

Reviewed by Ryosuke Niwa.

* Source/WTF/wtf/RefCountedWithWeakPtr.h: Added. For now, this class is just
a convenience to do the right thing by default without extra typing. In the
future I plan to optimize by combining the two separate implementations.

* Source/WebKit/NetworkProcess/Downloads/PendingDownload.h: Make it refcounted.

Canonical link: https://commits.webkit.org/283792@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications