[webkit-changes] [WebKit/WebKit] 27ffa9: [JSC] replace m_frozenValuesAreFinalized check wit...

[Dan Hecht]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 27ffa956d3fb3be64eb9a67391109aa42d50e735
      https://github.com/WebKit/WebKit/commit/27ffa956d3fb3be64eb9a67391109aa42d50e735
  Author: Dan Hecht <dan.hecht at apple.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGGraph.cpp
    M Source/JavaScriptCore/dfg/DFGGraph.h
    M Source/JavaScriptCore/ftl/FTLCompile.cpp
    M Source/JavaScriptCore/jit/JITPlan.cpp
    M Source/JavaScriptCore/jit/JITPlan.h

  Log Message:
  -----------
  [JSC] replace m_frozenValuesAreFinalized check with safepoint check
https://bugs.webkit.org/show_bug.cgi?id=279824
rdar://136150059

Reviewed by Yusuke Suzuki.

Now that the plan knows whether the compiler is inside a GC safepoint
or not we can directly check that rather than having separate
state for this assertion. That will be more robust if we allow more
compilation to occur within a GC safepoint. Also, the name
m_frozenValuesAreFinalized was misleading since it is not a "final"
state.

* Source/JavaScriptCore/dfg/DFGGraph.cpp:
(JSC::DFG::Graph::freeze):
* Source/JavaScriptCore/dfg/DFGGraph.h:
* Source/JavaScriptCore/ftl/FTLCompile.cpp:
(JSC::FTL::compile):
* Source/JavaScriptCore/jit/JITPlan.cpp:
(JSC::JITPlan::isInSafepoint const):
* Source/JavaScriptCore/jit/JITPlan.h:

Canonical link: https://commits.webkit.org/283789@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications