[webkit-changes] [WebKit/WebKit] f06b05: [JSC] Remove useWasmJITLessJSEntrypoint option

Yusuke Suzuki noreply at github.com
Tue Sep 17 00:37:10 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f06b058c97b0569042d34a415df9dbf370dcd303
      https://github.com/WebKit/WebKit/commit/f06b058c97b0569042d34a415df9dbf370dcd303
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    M JSTests/microbenchmarks/wasm-cc-int-to-int.js
    M JSTests/wasm/stress/cc-double-to-double.js
    M JSTests/wasm/stress/cc-f32-kitchen-sink.js
    M JSTests/wasm/stress/cc-float-to-float.js
    M JSTests/wasm/stress/cc-funcref.js
    M JSTests/wasm/stress/cc-i32-kitchen-sink-neg.js
    M JSTests/wasm/stress/cc-i32-kitchen-sink.js
    M JSTests/wasm/stress/cc-i64-kitchen-sink-neg.js
    M JSTests/wasm/stress/cc-i64-kitchen-sink.js
    M JSTests/wasm/stress/cc-infinite-int-glitch.js
    M JSTests/wasm/stress/cc-int-to-int-cross-module-with-exception.js
    M JSTests/wasm/stress/cc-int-to-int-cross-module.js
    M JSTests/wasm/stress/cc-int-to-int-memory.js
    M JSTests/wasm/stress/cc-int-to-int-no-jit.js
    M JSTests/wasm/stress/cc-int-to-int-to-js.js
    M JSTests/wasm/stress/cc-int-to-int.js
    M JSTests/wasm/stress/cc-lotsofints-to-int.js
    M JSTests/wasm/stress/cc-so-i-heard-you-like-parameters.js
    M Source/JavaScriptCore/llint/WebAssembly.asm
    M Source/JavaScriptCore/runtime/Options.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmCallee.cpp
    M Source/JavaScriptCore/wasm/WasmCallee.h
    M Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp
    M Source/JavaScriptCore/wasm/WasmOperations.cpp

  Log Message:
  -----------
  [JSC] Remove useWasmJITLessJSEntrypoint option
https://bugs.webkit.org/show_bug.cgi?id=279802
rdar://136116308

Reviewed by Ross Kirsling and Mark Lam.

283638 at main removed JSEntrypointJITCallee. This means useWasmJITLessJSEntrypoint must be always true
for wasm enablement. So putting it to false breaks wasm execution. This patch removes this broken option.

* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::disableAllJITOptions):
* Source/JavaScriptCore/runtime/OptionsList.h:
* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::compileFunction):
* Source/JavaScriptCore/wasm/WasmCallee.cpp:
(JSC::Wasm::JSEntrypointCallee::JSEntrypointCallee):
* Source/JavaScriptCore/wasm/WasmCallee.h:
* Source/JavaScriptCore/wasm/WasmLLIntPlan.cpp:
(JSC::Wasm::LLIntPlan::ensureEntrypoint):
(JSC::Wasm::LLIntPlan::didCompleteCompilation):
* Source/JavaScriptCore/wasm/WasmOperations.cpp:
(JSC::Wasm::JSC_DEFINE_JIT_OPERATION):

Canonical link: https://commits.webkit.org/283756@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list