[webkit-changes] [WebKit/WebKit] a32549: REGRESSION(/276827 at main): Large animated images ar...

Said Abou-Hallawa noreply at github.com
Tue Sep 17 00:24:29 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a3254962b06ea7d5c00a91bd11a609c1ad47a167
      https://github.com/WebKit/WebKit/commit/a3254962b06ea7d5c00a91bd11a609c1ad47a167
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2024-09-17 (Tue, 17 Sep 2024)

  Changed paths:
    A LayoutTests/fast/images/async-image-large-animated-disabled-expected.txt
    A LayoutTests/fast/images/async-image-large-animated-disabled.html
    A LayoutTests/fast/images/resources/animated-red-green-blue-400x400.gif
    M Source/WebCore/platform/graphics/BitmapImageSource.cpp
    M Source/WebCore/rendering/RenderBoxModelObject.cpp

  Log Message:
  -----------
  REGRESSION(/276827 at main): Large animated images are always decoded asynchronously
https://bugs.webkit.org/show_bug.cgi?id=278593
rdar://134597661

Reviewed by Simon Fraser.

The large animated images should be decoded asynchronously if the setting
AnimatedImageAsyncDecodingEnabled is true. The only exception is the first frame
has to be decoded synchronously only for the first time.

* LayoutTests/fast/images/async-image-large-animated-disabled-expected.txt: Added.
* LayoutTests/fast/images/async-image-large-animated-disabled.html: Added.
* LayoutTests/fast/images/resources/animated-red-green-blue-400x400.gif: Added.
* Source/WebCore/platform/graphics/BitmapImageSource.cpp:
(WebCore::BitmapImageSource::startAnimation):
(WebCore::BitmapImageSource::imageFrameDecodeAtIndexHasFinished):
(WebCore::BitmapImageSource::cacheNativeImageAtIndex):
(WebCore::BitmapImageSource::currentNativeImageForDrawing):
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::decodingModeForImageDraw const):

Canonical link: https://commits.webkit.org/283753@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list