[webkit-changes] [WebKit/WebKit] 782da0: TestWebKitAPI.AdaptiveImageGlyph.InsertWKAttachmen...

Aditya Keerthi noreply at github.com
Mon Sep 16 17:59:06 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 782da04d96266e5d3144aae185bed07566a6392f
      https://github.com/WebKit/WebKit/commit/782da04d96266e5d3144aae185bed07566a6392f
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/AdaptiveImageGlyph.mm

  Log Message:
  -----------
  TestWebKitAPI.AdaptiveImageGlyph.InsertWKAttachmentsOnPaste is failing
https://bugs.webkit.org/show_bug.cgi?id=279776
rdar://133719082

Reviewed by Abrar Rahman Protyasha.

Adaptive image glyphs may gain additional metadata when created by the system.
Since the sample test files do not have this metadata, the size may increase,
resulting in test failures due to inequality.

Fix by using `EXPECT_GE` rather than `EXPECT_EQ`, which still asserts that data
is not lost.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/AdaptiveImageGlyph.mm:
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertAndRemoveWKAttachments)):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertWKAttachmentsOnPaste)):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertWKAttachmentsCopyFromWebViewPasteToWebView)):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertWKAttachmentsMovingParagraphs)):

Canonical link: https://commits.webkit.org/283737@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list