[webkit-changes] [WebKit/WebKit] 4a826b: [WritingTools] All text disappears upon animation ...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a826bf145c611e5ea9f1700fc3ec7d0b5f4b506
      https://github.com/WebKit/WebKit/commit/4a826bf145c611e5ea9f1700fc3ec7d0b5f4b506
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm

  Log Message:
  -----------
  [WritingTools] All text disappears upon animation of rewrite retry in Mail compose.
rdar://135918945
https://bugs.webkit.org/show_bug.cgi?id=279709

Reviewed by Aditya Keerthi.

Completion handler and active animation were not being reset, so on
a restart we got into a bad state and crashed.

* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm:
(WebKit::TextAnimationController::addSourceTextAnimationForActiveWritingToolsSession):
(WebKit::TextAnimationController::addDestinationTextAnimationForActiveWritingToolsSession):
(WebKit::TextAnimationController::clearAnimationsForActiveWritingToolsSession):

Canonical link: https://commits.webkit.org/283722@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications