[webkit-changes] [WebKit/WebKit] da4713: [SVG2] Remove non-standard `kerning` property

Mon Sep 16 13:00:12 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: da471318105a38375ec838d0edb6d6787b9c4432
      https://github.com/WebKit/WebKit/commit/da471318105a38375ec838d0edb6d6787b9c4432
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
    M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt
    M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
    M LayoutTests/fast/css/getComputedStyle/resources/property-names.js
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt
    M LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/glib/svg/batik/text/textLayout-expected.txt
    M LayoutTests/platform/glib/svg/batik/text/textOnPathSpaces-expected.txt
    R LayoutTests/platform/gtk/svg/batik/text/textLayout-expected.png
    A LayoutTests/platform/gtk/svg/batik/text/textLayout-expected.txt
    R LayoutTests/platform/gtk/svg/batik/text/textOnPathSpaces-expected.png
    A LayoutTests/platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/ios/svg/batik/text/textLayout-expected.txt
    M LayoutTests/platform/ios/svg/batik/text/textOnPathSpaces-expected.txt
    M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt
    M LayoutTests/platform/mac/svg/batik/text/textLayout-expected.txt
    M LayoutTests/platform/mac/svg/batik/text/textOnPathSpaces-expected.txt
    M LayoutTests/svg/css/getComputedStyle-basic-expected.txt
    M LayoutTests/svg/css/parse-calc-length-expected.txt
    M LayoutTests/svg/css/parse-calc-length.html
    M LayoutTests/transitions/svg-transitions-expected.txt
    M LayoutTests/transitions/svg-transitions.html
    M Source/WebCore/animation/CSSPropertyAnimation.cpp
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp
    M Source/WebCore/rendering/style/SVGRenderStyle.cpp
    M Source/WebCore/rendering/style/SVGRenderStyle.h
    M Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp
    M Source/WebCore/rendering/style/SVGRenderStyleDefs.h
    M Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutEngineSpacing.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutEngineSpacing.h
    M Source/WebCore/svg/SVGElement.cpp
    M Source/WebCore/svg/properties/SVGPropertyAnimatorFactory.h
    M Source/WebCore/svg/svgattrs.in

  Log Message:
  -----------
  [SVG2] Remove non-standard `kerning` property

https://bugs.webkit.org/show_bug.cgi?id=262847
rdar://116965514

Reviewed by Simon Fraser.

This patch is to align WebKit with Gecko / Firefox, Blink / Chromium and
Web Specification [1].

[1] https://svgwg.org/svg2-draft/single-page.html#text-KerningProperty

It was discussed in W3C mailing list [2] to opt for CSS `font-kerning`.

[2] https://lists.w3.org/Archives/Public/www-svg/2012May/0101.html

It was never supported by Gecko / Firefox, while removed by Blnk in 2014 [3].

[3] https://github.com/chromium/chromium/commit/5f83d02185deb573a236459e03e069445808a981

* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::svgPropertyValue const):
* Source/WebCore/rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::SVGRenderStyle):
(WebCore::SVGRenderStyle::operator== const):
(WebCore::SVGRenderStyle::inheritedEqual const):
(WebCore::SVGRenderStyle::inheritFrom):
(WebCore::SVGRenderStyle::changeRequiresLayout const):
(WebCore::SVGRenderStyle::conservativelyCollectChangedAnimatableProperties const):
* Source/WebCore/rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::strokeDashOffset const):
(WebCore::RenderStyle::hasVisibleStroke const):
(WebCore::RenderStyle::setFloodOpacity):
(WebCore::SVGRenderStyle::initialKerning): Deleted.
(WebCore::SVGRenderStyle::kerning const): Deleted.
(WebCore::RenderStyle::kerning const): Deleted.
(WebCore::RenderStyle::setKerning): Deleted.
(WebCore::SVGRenderStyle::setKerning): Deleted.
* Source/WebCore/rendering/style/SVGRenderStyleDefs.cpp:
(WebCore::StyleTextData::StyleTextData): Deleted.
(WebCore::StyleTextData::copy const): Deleted.
(WebCore::StyleTextData::operator== const): Deleted.
* Source/WebCore/rendering/style/SVGRenderStyleDefs.h:
(WebCore::StyleTextData::create): Deleted.
* Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* Source/WebCore/rendering/svg/SVGTextLayoutEngineSpacing.cpp:
(WebCore::SVGTextLayoutEngineSpacing::calculateCSSSpacing):
(WebCore::SVGTextLayoutEngineSpacing::calculateCSSKerningAndSpacing): Deleted.
* Source/WebCore/rendering/svg/SVGTextLayoutEngineSpacing.h:
* Source/WebCore/svg/SVGElement.cpp:
(WebCore::SVGElement::cssPropertyIdForSVGAttributeName):
* Source/WebCore/svg/properties/SVGPropertyAnimatorFactory.h:
(WebCore::SVGPropertyAnimatorFactory::attributeAnimatorCreator):
* Source/WebCore/svg/svgattrs.in:
* LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt:
* LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* LayoutTests/fast/css/getComputedStyle/resources/property-names.js:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/glib/svg/batik/text/textLayout-expected.txt:
* LayoutTests/platform/glib/svg/batik/text/textOnPathSpaces-expected.txt:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/ios/svg/batik/text/textLayout-expected.txt:
* LayoutTests/platform/ios/svg/batik/text/textOnPathSpaces-expected.txt:
* LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/css-cascade/all-prop-revert-layer-expected.txt:
* LayoutTests/platform/mac/svg/batik/text/textLayout-expected.txt:
* LayoutTests/platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
* LayoutTests/svg/css/getComputedStyle-basic-expected.txt:
* LayoutTests/svg/css/parse-calc-length-expected.txt:
* LayoutTests/svg/css/parse-calc-length.html:
* LayoutTests/transitions/svg-transitions-expected.txt:
* LayoutTests/transitions/svg-transitions.html:
* LayoutTests/platform/gtk/svg/batik/text/textLayout-expected.png: Deleted.
* LayoutTests/platform/gtk/svg/batik/text/textLayout-expected.txt:
* LayoutTests/platform/gtk/svg/batik/text/textOnPathSpaces-expected.png: Deleted.
* LayoutTests/platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:

Canonical link: https://commits.webkit.org/283718@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications