[webkit-changes] [WebKit/WebKit] 031e1a: Table layout inconsistency with <td withd="100%">

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 031e1a8d56a5aa0a9c30f049b40cf0b3cb9902b8
      https://github.com/WebKit/WebKit/commit/031e1a8d56a5aa0a9c30f049b40cf0b3cb9902b8
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-16 (Mon, 16 Sep 2024)

  Changed paths:
    A LayoutTests/fast/table/stretchy-table-with-percent-cell-expected.html
    A LayoutTests/fast/table/stretchy-table-with-percent-cell.html
    M LayoutTests/platform/ios/fast/table/024-expected.txt
    M LayoutTests/platform/ios/fast/table/tableInsideCaption-expected.txt
    M LayoutTests/platform/mac/fast/table/024-expected.txt
    M LayoutTests/platform/mac/fast/table/tableInsideCaption-expected.txt
    M Source/WebCore/rendering/AutoTableLayout.cpp

  Log Message:
  -----------
  Table layout inconsistency with <td withd="100%">
https://bugs.webkit.org/show_bug.cgi?id=279450

Reviewed by Antti Koivisto.

This is about removing an old quirk (3673 at main) which was added to make excite.com look better by
not letting percent based cell bloat in some cases (nested table, auto width).
While it might visually be the preferred approach, it hurts interoperability as neither Blink nor Gecko adopted it.
It is also inconsistent as when the container of such table content is not an other table
but a min-content sized block container we stop applying this quirk and let the cell bloat.

(LayoutTests are progressions and now we match Blink)

* LayoutTests/fast/table/stretchy-table-with-percent-cell-expected.html: Added.
* LayoutTests/fast/table/stretchy-table-with-percent-cell.html: Added.
* Source/WebCore/rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::shouldScaleColumnsForSelf): Deleted.

Canonical link: https://commits.webkit.org/283711@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications