[webkit-changes] [WebKit/WebKit] d1370d: Fix LayoutTests/imported/w3c/web-platform-tests/cs...

Alan Baradlay noreply at github.com
Sun Sep 15 19:50:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d1370d8d93b0d9d13bd9f3b0a93c7b8662bbc75f
      https://github.com/WebKit/WebKit/commit/d1370d8d93b0d9d13bd9f3b0a93c7b8662bbc75f
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-15 (Sun, 15 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/line-clamp/webkit-line-clamp-025-expected.html

  Log Message:
  -----------
  Fix LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/line-clamp/webkit-line-clamp-025-expected.html
https://bugs.webkit.org/show_bug.cgi?id=279743

Reviewed by Cameron McCormack.

The expected content ends with an open <div> element and (preserved) trailing new line.
This trailing new line stretches the container when rendered by WebKit.

1. All engines agree when display value is set to flex (no stretching).
2. All engines agree when display value is set to block (stretching).
3. Blink and Gecko (no stretching) disagrees with WebKit (stretching) when display value is set to -webkit-box.

So essentially Blink and Gecko produces a flex like layout here for -webkit-box while WebKit does not.

Let's close the trailing <div> element to remove this ambiguity.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/line-clamp/webkit-line-clamp-025-expected.html:

Canonical link: https://commits.webkit.org/283688@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list