[webkit-changes] [WebKit/WebKit] 5f8c05: Inline SVGTextLayoutAttributes::emptyValue

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f8c05ccb28fbd0ab50b34be611409e4600eca70
      https://github.com/WebKit/WebKit/commit/5f8c05ccb28fbd0ab50b34be611409e4600eca70
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-09-15 (Sun, 15 Sep 2024)

  Changed paths:
    M Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutAttributes.h
    M Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp
    M Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp

  Log Message:
  -----------
  Inline SVGTextLayoutAttributes::emptyValue
https://bugs.webkit.org/show_bug.cgi?id=266260
rdar://119839011

Reviewed by Simon Fraser.

Merge: https://github.com/chromium/chromium/commit/d501a4d0cecb30041be93e549c909f8b3517a3fc

This function just returns a simple float - inlining it allows the
compiler to generate more efficient code (and smaller) code
since the relatively high overhead call can be eliminated.

* Source/WebCore/rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::characterStartsNewTextChunk const):
* Source/WebCore/rendering/svg/SVGTextLayoutAttributes.cpp:
(WebCore::SVGTextLayoutAttributes::emptyValue): Deleted.
* Source/WebCore/rendering/svg/SVGTextLayoutAttributes.h:
(WebCore::SVGTextLayoutAttributes::emptyValue):
(WebCore::SVGTextLayoutAttributes::isEmptyValue):
* Source/WebCore/rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):
* Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::updateCharacterPositionIfNeeded):
(WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

Canonical link: https://commits.webkit.org/283684@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications