[webkit-changes] [WebKit/WebKit] d54de3: Nested inlines' vertical alignment is wrong when l...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d54de3189d86187a7d640e2f54f9f57cfc2ffb4c
      https://github.com/WebKit/WebKit/commit/d54de3189d86187a7d640e2f54f9f57cfc2ffb4c
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-09-15 (Sun, 15 Sep 2024)

  Changed paths:
    A LayoutTests/fast/inline/nested-inline-boxes-with-line-fit-edge-expected.html
    A LayoutTests/fast/inline/nested-inline-boxes-with-line-fit-edge.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp

  Log Message:
  -----------
  Nested inlines' vertical alignment is wrong when line-fit-edge is set
https://bugs.webkit.org/show_bug.cgi?id=279699
<rdar://135962993>

Reviewed by Antti Koivisto.

Remove incorrect accumulation of line-fit-edge gap between text and the parent inline box's top edge. This value is only applicable between the text and its inline box and not across nested inline boxes.

* LayoutTests/fast/inline/nested-inline-boxes-with-line-fit-edge-expected.html: Added.
* LayoutTests/fast/inline/nested-inline-boxes-with-line-fit-edge.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBox.cpp:
(WebCore::Layout::LineBox::logicalRectForTextRun const):

Canonical link: https://commits.webkit.org/283682@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications