[webkit-changes] [WebKit/WebKit] ed9671: Improve HashTable::checkKey()

Chris Dumez noreply at github.com
Fri Sep 13 23:15:34 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed96717ba87eb2682e3ac06e5883417c1db58efc
      https://github.com/WebKit/WebKit/commit/ed96717ba87eb2682e3ac06e5883417c1db58efc
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/ImportMap.cpp
    M Source/WTF/wtf/HashTable.h
    M Source/WebCore/style/AnchorPositionEvaluator.cpp

  Log Message:
  -----------
  Improve HashTable::checkKey()
https://bugs.webkit.org/show_bug.cgi?id=279686

Reviewed by Darin Adler.

update HashTable::checkKey() to rely on KeyTraits::isEmptyValue() & KeyTraits::isDeletedValue()
whenever possible. This is better for performance as it avoids constructing those values to do
an `==` comparison. This also enables us to validate the key in more cases. We would previously
not do ANY validation of the key if `HashFunctions::safeToCompareToEmptyOrDeleted` was false.

* Source/WTF/wtf/HashTable.h:
(WTF::KeyTraits>::checkKey):

Canonical link: https://commits.webkit.org/283670@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list