[webkit-changes] [WebKit/WebKit] fdd79f: Port WebExtension Display Strings to C++

[Jamie Murphy]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fdd79f3b8daaecb342721c8103d55f129b80ee38
      https://github.com/WebKit/WebKit/commit/fdd79f3b8daaecb342721c8103d55f129b80ee38
  Author: Jamie <hello at itsjamie.dev>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    M Source/WTF/wtf/JSONValues.h
    M Source/WebKit/Sources.txt
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    A Source/WebKit/UIProcess/Extensions/WebExtension.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtension.h

  Log Message:
  -----------
  Port WebExtension Display Strings to C++
https://webkit.org/b/279610

Reviewed by Timothy Hatcher.

Create a JSON manifest to use in parallel with the Cocoa NSDictionary, and port the Display Strings to C++ (version, name, description).

* Source/WTF/wtf/JSONValues.h:
(WTF::JSONImpl::Value::operator! const):
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::WebExtension):
(WebKit::WebExtension::parseManifest):
(WebKit::WebExtension::manifestParsedSuccessfully): Deleted
(WebKit::WebExtension::manifestVersion): Deleted.
(WebKit::WebExtension::displayName): Deleted.
(WebKit::WebExtension::displayShortName): Deleted.
(WebKit::WebExtension::displayVersion): Deleted.
(WebKit::WebExtension::displayDescription): Deleted.
(WebKit::WebExtension::version): Deleted.
(WebKit::WebExtension::populateDisplayStringsIfNeeded): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp: Added.
(WebKit::WebExtension::manifestParsedSuccessfuly):
(WebKit::WebExtension::manifestObject):
(WebKit::WebExtension::manifestVersion):
(WebKit::WebExtension::displayName):
(WebKit::WebExtension::displayShortName):
(WebKit::WebExtension::displayVersion):
(WebKit::WebExtension::displayDescription):
(WebKit::WebExtension::version):
(WebKit::WebExtension::populateDisplayStringsIfNeeded):
* Source/WebKit/UIProcess/Extensions/WebExtension.h:

Canonical link: https://commits.webkit.org/283662@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications