[webkit-changes] [WebKit/WebKit] 1eb32c: [WebGPU] A retained MTLSamplerState can result us ...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1eb32c1b3c5eaf46ef64a1852e73c845bd755f5f
      https://github.com/WebKit/WebKit/commit/1eb32c1b3c5eaf46ef64a1852e73c845bd755f5f
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-279542-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-279542.html
    M Source/WebGPU/WebGPU/Sampler.h
    M Source/WebGPU/WebGPU/Sampler.mm

  Log Message:
  -----------
  [WebGPU] A retained MTLSamplerState can result us in exceeding the MTLSamplerState limit
https://bugs.webkit.org/show_bug.cgi?id=279542
radar://135708279

Reviewed by Dan Glastonbury.

We were tracking internally the number of samplers to ensure we didn't exceed
the process limit for MTLSamplerState instances.

This is problematic when a MTLSamplerState is retained outside the cache, e.g.,
in a pending MTLCommandBuffer.

Handle this by overriding dealloc in order to track the real alive count.

* LayoutTests/fast/webgpu/nocrash/fuzz-279542-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-279542.html: Added.
* Source/WebGPU/WebGPU/Sampler.h:
* Source/WebGPU/WebGPU/Sampler.mm:
(WebGPU::Sampler::deallocSamplerState):
(WebGPU::Sampler::Sampler):
(WebGPU::Sampler::samplerState const):

Canonical link: https://commits.webkit.org/283645@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications