[webkit-changes] [WebKit/WebKit] cdc5ff: Enable Modern Download Progress by default

[Per Arne Vollan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cdc5ff23179423f4e5498b56702d0d95dfa02ae8
      https://github.com/WebKit/WebKit/commit/cdc5ff23179423f4e5498b56702d0d95dfa02ae8
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/Downloads/Download.h
    M Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp
    M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
    M Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp
    M Source/WebKit/NetworkProcess/Downloads/PendingDownload.h
    M Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/UIProcess/API/Cocoa/WKDownloadDelegatePrivate.h
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.h
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.messages.in
    M Source/WebKit/UIProcess/Downloads/DownloadProxyCocoa.mm

  Log Message:
  -----------
  Enable Modern Download Progress by default
https://bugs.webkit.org/show_bug.cgi?id=279543
rdar://135826595

Reviewed by Chris Dumez.

Remove the runtime check for enabling Modern Download Progress. This patch also addresses sandbox
violations observed by issuing and consuming file sandbox extensions. One sandbox extension is
created for the placeholder file of the download. This sandbox extension is being sent from the
UI process to the Networking process, and is required for setting the xattr on the file.
Sandbox extensions are also created for the placeholder file and final destination file and sent
from the Networking process to the UI process. These sandbox extensions are required for the UI
process to be able to create bookmarks from these locations, so they can be located after being
moved or deleted.

* Source/WebKit/NetworkProcess/Downloads/Download.h:
* Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::publishDownloadProgress):
* Source/WebKit/NetworkProcess/Downloads/DownloadManager.h:
* Source/WebKit/NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::publishProgress):
(WebKit::PendingDownload::didBecomeDownload):
* Source/WebKit/NetworkProcess/Downloads/PendingDownload.h:
* Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::platformDestroyDownload):
(WebKit::Download::publishProgress):
(WebKit::Download::setPlaceholderURL):
(WebKit::Download::setFinalURL):
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::publishDownloadProgress):
(WebKit::NetworkProcess::findPendingDownloadLocation):
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/UIProcess/API/Cocoa/WKDownloadDelegatePrivate.h:
* Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.h:
* Source/WebKit/UIProcess/Downloads/DownloadProxy.messages.in:
* Source/WebKit/UIProcess/Downloads/DownloadProxyCocoa.mm:
(WebKit::DownloadProxy::publishProgress):
(WebKit::DownloadProxy::didReceivePlaceholderURL):
(WebKit::DownloadProxy::didReceiveFinalURL):
(WebKit::DownloadProxy::bookmarkDataForURL):
(WebKit::DownloadProxy::activityAccessToken):

Canonical link: https://commits.webkit.org/283642@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications