[webkit-changes] [WebKit/WebKit] 64e087: Remove LegacyReceiver from all Process message rec...

Fri Sep 13 10:46:17 PDT 2024

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 64e0879489042142d935d6b615999b111bc1a5e1
      https://github.com/WebKit/WebKit/commit/64e0879489042142d935d6b615999b111bc1a5e1
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    M Source/WebKit/GPUProcess/GPUProcess.cpp
    M Source/WebKit/GPUProcess/GPUProcess.h
    M Source/WebKit/GPUProcess/GPUProcess.messages.in
    M Source/WebKit/ModelProcess/ModelProcess.cpp
    M Source/WebKit/ModelProcess/ModelProcess.h
    M Source/WebKit/ModelProcess/ModelProcess.messages.in
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkProcess.h
    M Source/WebKit/NetworkProcess/NetworkProcess.messages.in
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Scripts/webkit/messages_unittest.py
    M Source/WebKit/Scripts/webkit/tests/Makefile
    M Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp
    M Source/WebKit/Scripts/webkit/tests/MessageNames.cpp
    M Source/WebKit/Scripts/webkit/tests/MessageNames.h
    A Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsAsyncDispatch.messages.in
    A Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsAsyncDispatchMessageReceiver.cpp
    A Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsAsyncDispatchMessages.h
    A Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsDispatch.messages.in
    A Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsDispatchMessageReceiver.cpp
    A Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsDispatchMessages.h
    M Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsAsyncDispatch.messages.in
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsAsyncDispatchMessageReceiver.cpp
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsAsyncDispatchMessages.h
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatch.messages.in
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchMessageReceiver.cpp
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchMessages.h
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchNoSyncMessages.messages.in
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchNoSyncMessagesMessageReceiver.cpp
    A Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchNoSyncMessagesMessages.h
    M Source/WebKit/Shared/AuxiliaryProcess.cpp
    M Source/WebKit/Shared/AuxiliaryProcess.h
    M Source/WebKit/Shared/AuxiliaryProcess.messages.in
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/WebProcess.messages.in

  Log Message:
  -----------
  Remove LegacyReceiver from all Process message receivers
https://bugs.webkit.org/show_bug.cgi?id=279582
rdar://135859566

Reviewed by Chris Dumez.

Avoid forwarding the messages manually, rather mark the message
receivers as having AuxiliaryProcess as the superclass.

Fix superclass implementation to generate call to superclass sync
message handling code.

This is work towads simplifying delivery of messages by being able to
remove LegacyReceiver implementation.

* Source/WebKit/GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::didReceiveMessage): Deleted.
* Source/WebKit/GPUProcess/GPUProcess.h:
(WebKit::GPUProcess::sharedSceneContext): Deleted.
(WebKit::GPUProcess::applicationVisibleName const): Deleted.
* Source/WebKit/GPUProcess/GPUProcess.messages.in:
* Source/WebKit/ModelProcess/ModelProcess.cpp:
(WebKit::ModelProcess::didReceiveMessage): Deleted.
* Source/WebKit/ModelProcess/ModelProcess.h:
(WebKit::ModelProcess::applicationVisibleName const): Deleted.
* Source/WebKit/ModelProcess/ModelProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::dispatchMessage):
(WebKit::NetworkProcess::didReceiveMessage): Deleted.
(WebKit::NetworkProcess::didReceiveSyncMessage): Deleted.
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/Scripts/webkit/messages.py:
(generate_message_handler):
* Source/WebKit/Scripts/webkit/tests/Makefile:
* Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:
(IPC::jsValueForArguments):
(IPC::jsValueForReplyArguments):
(IPC::messageArgumentDescriptions):
(IPC::messageReplyArgumentDescriptions):
* Source/WebKit/Scripts/webkit/tests/MessageNames.cpp:
* Source/WebKit/Scripts/webkit/tests/MessageNames.h:
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsAsyncDispatch.messages.in: Copied from Source/WebKit/Shared/AuxiliaryProcess.messages.in.
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsAsyncDispatchMessageReceiver.cpp: Added.
(WebKit::TestWithSuperclassAndWantsAsyncDispatch::didReceiveMessage):
(WebKit::TestWithSuperclassAndWantsAsyncDispatch::didReceiveSyncMessage):
(IPC::jsValueForDecodedMessage<MessageName::TestWithSuperclassAndWantsAsyncDispatch_LoadURL>):
(IPC::jsValueForDecodedMessage<MessageName::TestWithSuperclassAndWantsAsyncDispatch_TestSyncMessage>):
(IPC::jsValueForDecodedMessageReply<MessageName::TestWithSuperclassAndWantsAsyncDispatch_TestSyncMessage>):
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsAsyncDispatchMessages.h: Added.
(Messages::TestWithSuperclassAndWantsAsyncDispatch::messageReceiverName):
(Messages::TestWithSuperclassAndWantsAsyncDispatch::LoadURL::name):
(Messages::TestWithSuperclassAndWantsAsyncDispatch::LoadURL::LoadURL):
(Messages::TestWithSuperclassAndWantsAsyncDispatch::LoadURL::arguments):
(Messages::TestWithSuperclassAndWantsAsyncDispatch::TestSyncMessage::name):
(Messages::TestWithSuperclassAndWantsAsyncDispatch::TestSyncMessage::TestSyncMessage):
(Messages::TestWithSuperclassAndWantsAsyncDispatch::TestSyncMessage::arguments):
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsDispatch.messages.in: Copied from Source/WebKit/Shared/AuxiliaryProcess.messages.in.
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsDispatchMessageReceiver.cpp: Added.
(WebKit::TestWithSuperclassAndWantsDispatch::didReceiveMessage):
(WebKit::TestWithSuperclassAndWantsDispatch::didReceiveSyncMessage):
(IPC::jsValueForDecodedMessage<MessageName::TestWithSuperclassAndWantsDispatch_LoadURL>):
(IPC::jsValueForDecodedMessage<MessageName::TestWithSuperclassAndWantsDispatch_TestSyncMessage>):
(IPC::jsValueForDecodedMessageReply<MessageName::TestWithSuperclassAndWantsDispatch_TestSyncMessage>):
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassAndWantsDispatchMessages.h: Added.
(Messages::TestWithSuperclassAndWantsDispatch::messageReceiverName):
(Messages::TestWithSuperclassAndWantsDispatch::LoadURL::name):
(Messages::TestWithSuperclassAndWantsDispatch::LoadURL::LoadURL):
(Messages::TestWithSuperclassAndWantsDispatch::LoadURL::arguments):
(Messages::TestWithSuperclassAndWantsDispatch::TestSyncMessage::name):
(Messages::TestWithSuperclassAndWantsDispatch::TestSyncMessage::TestSyncMessage):
(Messages::TestWithSuperclassAndWantsDispatch::TestSyncMessage::arguments):
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp:
(WebKit::TestWithSuperclass::didReceiveSyncMessage):
* Source/WebKit/Scripts/webkit/tests/TestWithWantsAsyncDispatch.messages.in: Copied from Source/WebKit/Shared/AuxiliaryProcess.messages.in.
* Source/WebKit/Scripts/webkit/tests/TestWithWantsAsyncDispatchMessageReceiver.cpp: Added.
(WebKit::TestWithWantsAsyncDispatch::didReceiveMessage):
(WebKit::TestWithWantsAsyncDispatch::didReceiveSyncMessage):
(IPC::jsValueForDecodedMessage<MessageName::TestWithWantsAsyncDispatch_TestMessage>):
(IPC::jsValueForDecodedMessage<MessageName::TestWithWantsAsyncDispatch_TestSyncMessage>):
(IPC::jsValueForDecodedMessageReply<MessageName::TestWithWantsAsyncDispatch_TestSyncMessage>):
* Source/WebKit/Scripts/webkit/tests/TestWithWantsAsyncDispatchMessages.h: Added.
(Messages::TestWithWantsAsyncDispatch::messageReceiverName):
(Messages::TestWithWantsAsyncDispatch::TestMessage::name):
(Messages::TestWithWantsAsyncDispatch::TestMessage::TestMessage):
(Messages::TestWithWantsAsyncDispatch::TestMessage::arguments):
(Messages::TestWithWantsAsyncDispatch::TestSyncMessage::name):
(Messages::TestWithWantsAsyncDispatch::TestSyncMessage::TestSyncMessage):
(Messages::TestWithWantsAsyncDispatch::TestSyncMessage::arguments):
* Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatch.messages.in: Copied from Source/WebKit/Shared/AuxiliaryProcess.messages.in.
* Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchMessageReceiver.cpp: Added.
(WebKit::TestWithWantsDispatch::didReceiveMessage):
(WebKit::TestWithWantsDispatch::didReceiveSyncMessage):
(IPC::jsValueForDecodedMessage<MessageName::TestWithWantsDispatch_TestMessage>):
(IPC::jsValueForDecodedMessage<MessageName::TestWithWantsDispatch_TestSyncMessage>):
(IPC::jsValueForDecodedMessageReply<MessageName::TestWithWantsDispatch_TestSyncMessage>):
* Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchMessages.h: Added.
(Messages::TestWithWantsDispatch::messageReceiverName):
(Messages::TestWithWantsDispatch::TestMessage::name):
(Messages::TestWithWantsDispatch::TestMessage::TestMessage):
(Messages::TestWithWantsDispatch::TestMessage::arguments):
(Messages::TestWithWantsDispatch::TestSyncMessage::name):
(Messages::TestWithWantsDispatch::TestSyncMessage::TestSyncMessage):
(Messages::TestWithWantsDispatch::TestSyncMessage::arguments):
* Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchNoSyncMessages.messages.in: Copied from Source/WebKit/Shared/AuxiliaryProcess.messages.in.
* Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchNoSyncMessagesMessageReceiver.cpp: Added.
(WebKit::TestWithWantsDispatchNoSyncMessages::didReceiveMessage):
(WebKit::TestWithWantsDispatchNoSyncMessages::didReceiveSyncMessage):
(IPC::jsValueForDecodedMessage<MessageName::TestWithWantsDispatchNoSyncMessages_TestMessage>):
* Source/WebKit/Scripts/webkit/tests/TestWithWantsDispatchNoSyncMessagesMessages.h: Added.
(Messages::TestWithWantsDispatchNoSyncMessages::messageReceiverName):
(Messages::TestWithWantsDispatchNoSyncMessages::TestMessage::name):
(Messages::TestWithWantsDispatchNoSyncMessages::TestMessage::TestMessage):
(Messages::TestWithWantsDispatchNoSyncMessages::TestMessage::arguments):
* Source/WebKit/Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::dispatchMessage):
(WebKit::AuxiliaryProcess::dispatchSyncMessage):
* Source/WebKit/Shared/AuxiliaryProcess.h:
* Source/WebKit/Shared/AuxiliaryProcess.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::dispatchMessage):
(WebKit::WebProcess::didReceiveSyncMessage): Deleted.
(WebKit::WebProcess::didReceiveMessage): Deleted.
* Source/WebKit/WebProcess/WebProcess.h:
(WebKit::WebProcess::supplement): Deleted.
(WebKit::WebProcess::addSupplement): Deleted.
(WebKit::WebProcess::hasEverHadAnyWebPages const): Deleted.
(WebKit::WebProcess::isWebTransportEnabled const): Deleted.
(WebKit::WebProcess::injectedBundle const): Deleted.
(WebKit::WebProcess::sessionID const): Deleted.
(WebKit::WebProcess::thirdPartyCookieBlockingMode const): Deleted.
(WebKit::WebProcess::compositingRenderServerPort const): Deleted.
(WebKit::WebProcess::setCompositingRenderServerPort): Deleted.
(WebKit::WebProcess::fullKeyboardAccessEnabled const): Deleted.
(WebKit::WebProcess::hasMouseDevice const): Deleted.
(WebKit::WebProcess::hasStylusDevice const): Deleted.
(WebKit::WebProcess::textCheckerState const): Deleted.
(WebKit::WebProcess::eventDispatcher): Deleted.
(WebKit::WebProcess::existingNetworkProcessConnection): Deleted.
(WebKit::WebProcess::existingGPUProcessConnection): Deleted.
(WebKit::WebProcess::existingModelProcessConnection): Deleted.
(WebKit::WebProcess::uiProcessBundleIdentifier const): Deleted.
(WebKit::WebProcess::hasImageServices const): Deleted.
(WebKit::WebProcess::hasSelectionServices const): Deleted.
(WebKit::WebProcess::hasRichContentServices const): Deleted.
(WebKit::WebProcess::automationSessionProxy): Deleted.
(WebKit::WebProcess::modelProcessModelPlayerManager): Deleted.
(WebKit::WebProcess::cacheStorageProvider): Deleted.
(WebKit::WebProcess::badgeClient): Deleted.
(WebKit::WebProcess::remoteMediaPlayerManager): Deleted.
(WebKit::WebProcess::remoteImageDecoderAVFManager): Deleted.
(WebKit::WebProcess::broadcastChannelRegistry): Deleted.
(WebKit::WebProcess::cookieJar): Deleted.
(WebKit::WebProcess::webSocketChannelManager): Deleted.
(WebKit::WebProcess::backlightLevel const): Deleted.
(WebKit::WebProcess::isLockdownModeEnabled const): Deleted.
(WebKit::WebProcess::imageAnimationEnabled const): Deleted.
(WebKit::WebProcess::prefersNonBlinkingCursor const): Deleted.
(WebKit::WebProcess::setHadMainFrameMainResourcePrivateRelayed): Deleted.
(WebKit::WebProcess::hadMainFrameMainResourcePrivateRelayed const): Deleted.
(WebKit::WebProcess::dmaBufRendererBufferMode const): Deleted.
(WebKit::WebProcess::mediaKeysStorageDirectory const): Deleted.
(WebKit::WebProcess::mediaKeysStorageSalt const): Deleted.
* Source/WebKit/WebProcess/WebProcess.messages.in:

Canonical link: https://commits.webkit.org/283632@main

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications