[webkit-changes] [WebKit/WebKit] 8972ce: Rename WebPageProxy and LocalFrameLoaderClient fun...

[Ryan Reno]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8972ce9795a840738e367ae77a0ba98a0f639295
      https://github.com/WebKit/WebKit/commit/8972ce9795a840738e367ae77a0ba98a0f639295
  Author: Ryan Reno <rreno at apple.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h

  Log Message:
  -----------
  Rename WebPageProxy and LocalFrameLoaderClient functions to be less ambiguous
https://bugs.webkit.org/show_bug.cgi?id=278597
rdar://134603009

Reviewed by Chris Dumez.

didSameDocumentNavigationForFrameViaJSHistoryAPI can be called whenever
we are doing a same-document navigation such as when an anchor
element's click event handler navigates us to another part of the
document. This patch is a rename to the functions, log messages, and
IPC messages to hopefully be more clear that this represents any JS initiated same
document navigation not only same document navigations via the history
API.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaHistoryAPIOrJS):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrameViaJSHistoryAPI): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp:
(WebKit::WebLocalFrameLoaderClient::didSameDocumentNavigationForFrameViaHistoryAPIOrJS):
(WebKit::WebLocalFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebLocalFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebLocalFrameLoaderClient::dispatchDidPopStateWithinPage):
(WebKit::WebLocalFrameLoaderClient::didSameDocumentNavigationForFrameViaJSHistoryAPI): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h:

Canonical link: https://commits.webkit.org/283623@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications