[webkit-changes] [WebKit/WebKit] 732ebf: [JSC] Disable Options::useWasmFastMemory on PlaySt...

Ross Kirsling noreply at github.com
Fri Sep 13 08:14:11 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 732ebf7c5541f917b6d66e641a936dd4d9da145a
      https://github.com/WebKit/WebKit/commit/732ebf7c5541f917b6d66e641a936dd4d9da145a
  Author: Ross Kirsling <ross.kirsling at sony.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/Options.cpp

  Log Message:
  -----------
  [JSC] Disable Options::useWasmFastMemory on PlayStation
https://bugs.webkit.org/show_bug.cgi?id=279652

Reviewed by Keith Miller.

Instantiating wasm memory on PS (via the call `new WebAssembly.Memory({ initial: 1 })` or the instruction `(memory 1)`)
causes a crash in Gigacage::tryAllocateZeroedVirtualPages. It seems we should keep useWasmFastMemory off on our platform.

(Less than ideal to have this be a platform-specific guard, but I'm not sure what the right-sized condition would be.)

* Source/JavaScriptCore/runtime/Options.cpp:
(JSC::Options::notifyOptionsChanged):

Canonical link: https://commits.webkit.org/283618@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list