[webkit-changes] [WebKit/WebKit] c0f0e0: Remove Quirk isStorageAccessQuirkDomainAndElement ...

Karl Dubost noreply at github.com
Thu Sep 12 23:30:34 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0f0e06eae05d5b65ab4dfe6323f2072b6cf2cba
      https://github.com/WebKit/WebKit/commit/c0f0e06eae05d5b65ab4dfe6323f2072b6cf2cba
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp
    M Source/WebCore/platform/network/NetworkStorageSession.cpp

  Log Message:
  -----------
  Remove Quirk isStorageAccessQuirkDomainAndElement for gizmodo.com
https://bugs.webkit.org/show_bug.cgi?id=279636
rdar://135927150

Reviewed by Sihui Liu.

gizmodo is not part anymore of the Kinja login system.
They also have removed the icon at the top right which was initially
there. On some articles, there is the possibility to comment as Guest
or logged in which is powered by a different tracking company. After
testing with both Site Specific Hacks Enabled and Disabled, we can
conclude the login for comments is working.

The quirk is then not necessary anymore.

* Source/WebCore/page/Quirks.cpp:
(WebCore::isStorageAccessQuirkDomainAndElement):
(WebCore::elementHasClassInClosestAncestors): Deleted.
* Source/WebCore/platform/network/NetworkStorageSession.cpp:
(WebCore::NetworkStorageSession::storageAccessQuirks):

Canonical link: https://commits.webkit.org/283600@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list