[webkit-changes] [WebKit/WebKit] 402a27: Ensure CookieStoreManager is exposed only to Windo...

Rupin Mittal noreply at github.com
Thu Sep 12 17:55:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 402a2777996a7e7680023e5d3083801ab1de8d3e
      https://github.com/WebKit/WebKit/commit/402a2777996a7e7680023e5d3083801ab1de8d3e
  Author: Rupin Mittal <rupin at apple.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker-expected.txt
    M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
    M Source/WebCore/workers/service/ServiceWorkerRegistration.idl

  Log Message:
  -----------
  Ensure CookieStoreManager is exposed only to Window and ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=279573
rdar://135847353

Reviewed by Chris Dumez and Sihui Liu.

As per the Cookie Store API spec (https://wicg.github.io/cookie-store/#ServiceWorkerRegistration),
the ServiceWorkerRegistration interface gives access to a CookieStoreManager via cookies. This
cookies attribute should be exposed only to Window and ServiceWorker.

In order to support exposing this to ServiceWorker, we update CodeGeneratorJS.pm. Previously,
adding Exposed=ServiceWorker for a partial interface, or for a single attribute within an interface,
would result in an IDL parsing error.

* LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.sharedworker-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/cookie-store/idlharness.https.any.worker-expected.txt:
* Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:
(GenerateRuntimeEnableConditionalStringForExposeScope):
* Source/WebCore/workers/service/ServiceWorkerRegistration.idl:

Canonical link: https://commits.webkit.org/283588@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list