[webkit-changes] [WebKit/WebKit] 17d716: Remove Quirk triggerOptionalStorageAccessQuirk for...

Karl Dubost noreply at github.com
Thu Sep 12 15:02:42 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17d716bf82153f7018b0c8fea755d4825ef0a9ff
      https://github.com/WebKit/WebKit/commit/17d716bf82153f7018b0c8fea755d4825ef0a9ff
  Author: Karl Dubost <karlcow at apple.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M Source/WebCore/page/Quirks.cpp

  Log Message:
  -----------
  Remove Quirk triggerOptionalStorageAccessQuirk for domains not part of Kinja anymore
https://bugs.webkit.org/show_bug.cgi?id=279581
rdar://135854408

Reviewed by Brent Fulgham.

kinjaQuirks defines a list of domains to be used by the Quirk
triggerOptionalStorageAccessQuirk. This list is then used later in
addition to isKinjaLoginAvatarElement (another Quirk)

if (kinjaQuirks.get().contains(domain)
    && isKinjaLoginAvatarElement(element)) { … }

Some of these domains are not part anymore of Kinja Login system. They
can be removed.

The list of domains to remove is:

* avclub.com
* deadspin.com
* jezebel.com
* lifehacker.com
* thetakeout.com
* theonion.com

It would be good to check for the remaining domains if the quirk is
needed at all. The markup defined in isKinjaLoginAvatarElement still
exists.

* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

Canonical link: https://commits.webkit.org/283581@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list