[webkit-changes] [WebKit/WebKit] d80d6f: [Cocoa] Logging macros should use the correct OSLo...

Ryan Reno noreply at github.com
Thu Sep 12 14:31:41 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d80d6f2b54115e952e9f9f2fe7458d857c1375f7
      https://github.com/WebKit/WebKit/commit/d80d6f2b54115e952e9f9f2fe7458d857c1375f7
  Author: Ryan Reno <rreno at apple.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M Source/WTF/wtf/Assertions.cpp

  Log Message:
  -----------
  [Cocoa] Logging macros should use the correct OSLog category
https://bugs.webkit.org/show_bug.cgi?id=279553
rdar://135836583

Reviewed by Ben Nham.

Macros such as LOG or LOG_WITH_STREAM use the log channel passed to them
to determine whether or not they should log at all but we end up logging
to the Generic OSLog category. This change will pass the log channel
down to the os_log API calls so we can log to the correct subsystem and category
which will be "com.apple.WebKit:LogChannelName" for some LogChannelName.

This enables us to use the category predicate when streaming or viewing
logs offline.

* Source/WTF/wtf/Assertions.cpp:

Canonical link: https://commits.webkit.org/283578@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list