[webkit-changes] [WebKit/WebKit] 818118: HTML entity parsing hits SegmentedString::pushBack...

Vitaly Dyachkov noreply at github.com
Thu Sep 12 00:14:16 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 818118e729fb78d177e97861bd47b876808979c2
      https://github.com/WebKit/WebKit/commit/818118e729fb78d177e97861bd47b876808979c2
  Author: Vitaly Dyachkov <vitaly at igalia.com>
  Date:   2024-09-12 (Thu, 12 Sep 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/platform/text/SegmentedString.cpp

  Log Message:
  -----------
  HTML entity parsing hits SegmentedString::pushBack() assert through document.write()
https://bugs.webkit.org/show_bug.cgi?id=268217

Reviewed by Chris Dumez and Darin Adler.

When advancing past a single-character substring, we should always mark
such a substring as fully consumed (i.e., set its `length` to `0`),
and add its consumed character number to `m_numberOfCharactersConsumedPriorToCurrentSubstring`.

* LayoutTests/TestExpectations:
* Source/WebCore/platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::advancePastSingleCharacterSubstringWithoutUpdatingLineNumber):

Canonical link: https://commits.webkit.org/283540@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list