[webkit-changes] [WebKit/WebKit] 9bcf0c: [iOS] Subtitles are lost when moving between nativ...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9bcf0c6e31d573901fca607ff5f31bbf0ddc694f
      https://github.com/WebKit/WebKit/commit/9bcf0c6e31d573901fca607ff5f31bbf0ddc694f
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2024-09-11 (Wed, 11 Sep 2024)

  Changed paths:
    M Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm
    M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm

  Log Message:
  -----------
  [iOS] Subtitles are lost when moving between native fullscreen and pip modes
https://bugs.webkit.org/show_bug.cgi?id=279532
rdar://134372702

Reviewed by Andy Estes.

When moving the video content between fullscreen and PiP views, also move the
subtitle layer, taking care to place the video view below the subtitle layer
in the view heirarchy.

Also, to ensure VideoPresentationInterfaceAVKit::setupFullscreen() doesn't move
the subtitle layer back to the fullscreen WebAVPlayerLayer, only do so when
that layer does not have a captions layer to begin with.

* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm:
(WebCore::WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
(WebCore::WebAVPlayerLayerView_stopRoutingVideoToPictureInPicturePlayerLayerView):
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKit.mm:
(WebCore::VideoPresentationInterfaceAVKit::setupFullscreen):

Canonical link: https://commits.webkit.org/283518@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications