[webkit-changes] [WebKit/WebKit] ff0739: Weak-link BrowserEngineCore library on macOS

Marcus Plutowski noreply at github.com
Wed Sep 11 17:51:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ff07392359cf9e86c51ffd391b1b0915a619bf67
      https://github.com/WebKit/WebKit/commit/ff07392359cf9e86c51ffd391b1b0915a619bf67
  Author: Marcus Plutowski <marcus_plutowski at apple.com>
  Date:   2024-09-11 (Wed, 11 Sep 2024)

  Changed paths:
    M Source/JavaScriptCore/Configurations/Base.xcconfig
    M Source/WebCore/Configurations/WebCore.xcconfig

  Log Message:
  -----------
  Weak-link BrowserEngineCore library on macOS
https://bugs.webkit.org/show_bug.cgi?id=278066
rdar://133777782

Reviewed by Per Arne Vollan.

Currently we only link this on iOS due to some historical issues with
linking it more widely. Now, however, we should be able to use it on
macOS as well: doing so will allow us to de-duplicate some code that
currently needs to stay around for the sake of macOS.

I previously tried to strong-link this based on a hypothesis
(282930 at main) but it broke some obscure builds so we need to fall back
to weak-linking like we do on iOS.

* Source/JavaScriptCore/Configurations/Base.xcconfig:
* Source/WebCore/Configurations/WebCore.xcconfig:

Canonical link: https://commits.webkit.org/283511@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list