[webkit-changes] [WebKit/WebKit] 96606d: Storing loginStatus value in a database

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 96606df018fb75b2e6f5b643438712c2f642eafb
      https://github.com/WebKit/WebKit/commit/96606df018fb75b2e6f5b643438712c2f642eafb
  Author: Pouneh Bahrami <pbahrami at apple.com>
  Date:   2024-09-11 (Wed, 11 Sep 2024)

  Changed paths:
    M Source/WebCore/page/LoginStatus.cpp
    M Source/WebCore/page/LoginStatus.h
    M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp
    M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h
    M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
    M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h

  Log Message:
  -----------
  Storing loginStatus value in a database
https://bugs.webkit.org/show_bug.cgi?id=279162
rdar://135310202

Reviewed by Chris Dumez and Alex Christensen.

In the initial implementation, the loginStatus was stored in a temporary hashmap, and the status was cleared once the session ended. In this patch, we update the implementation to store the status persistently in the LoginStatus table within the observations.db database.
This functionality is covered by the layout test http/tests/login-status/login-status-api-getter-setter-functions.html.

* Source/WebCore/page/LoginStatus.cpp:
(WebCore::LoginStatus::isolatedCopy const):
(WebCore::LoginStatus::isolatedCopy):
* Source/WebCore/page/LoginStatus.h:
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:
(WebKit::ResourceLoadStatisticsStore::expectedTableAndIndexQueries):
(WebKit::ResourceLoadStatisticsStore::sortedTables):
(WebKit::ResourceLoadStatisticsStore::createSchema):
(WebKit::ResourceLoadStatisticsStore::destroyStatements):
(WebKit::ResourceLoadStatisticsStore::insertLoginStatus):
(WebKit::ResourceLoadStatisticsStore::removeLoginStatus):
(WebKit::ResourceLoadStatisticsStore::loginStatusExists):
(WebKit::ResourceLoadStatisticsStore::domainID const):
(WebKit::ResourceLoadStatisticsStore::loginStatusDomainID const):
(WebKit::ResourceLoadStatisticsStore::domainIDWithTable const):
(WebKit::ResourceLoadStatisticsStore::setLoginStatus):
(WebKit::ResourceLoadStatisticsStore::isLoggedIn):
* Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::setLoginStatus):
(WebKit::WebResourceLoadStatisticsStore::isLoggedIn):
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:

Canonical link: https://commits.webkit.org/283505@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications