[webkit-changes] [WebKit/WebKit] 1bbb00: [WebGPU] Nullptr crash in updateExternalTextures

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1bbb00302cefd8a0f52d1bdcf19c2db2985c08b8
      https://github.com/WebKit/WebKit/commit/1bbb00302cefd8a0f52d1bdcf19c2db2985c08b8
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-279449-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-279449.html
    M Source/WebGPU/WebGPU/BindGroup.mm

  Log Message:
  -----------
  [WebGPU] Nullptr crash in updateExternalTextures
https://bugs.webkit.org/show_bug.cgi?id=279449
rdar://135707307

Reviewed by Dan Glastonbury.

BindGroup's m_bindGroupLayout is a RefPtr, which is nullptr
when the bind group is invalid. We need to check for null
otherwise we will encounter a nullptr crash when an invalid
bind group is used with a valid external texture.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::BindGroup::rebindSamplersIfNeeded const):
(WebGPU::BindGroup::updateExternalTextures):

Canonical link: https://commits.webkit.org/283456@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications