[webkit-changes] [WebKit/WebKit] 3aeaf8: Remaining text still visible when animation is run...

[megangardner]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3aeaf8d06ed9516e282c3cefe9eb4c38aeb1a86d
      https://github.com/WebKit/WebKit/commit/3aeaf8d06ed9516e282c3cefe9eb4c38aeb1a86d
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm

  Log Message:
  -----------
  Remaining text still visible when animation is running.
https://bugs.webkit.org/show_bug.cgi?id=279389
rdar://135603636

Reviewed by Aditya Keerthi.

The range to turn off visibility was not set properly.
Also took the opportunity to give this a more descriptive name.

* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/TextAnimationController.mm:
(WebKit::TextAnimationController::contextRangeForTextAnimationID const):
(WebKit::TextAnimationController::removeTransparentMarkersForActiveWritingToolsSession):
(WebKit::TextAnimationController::addDestinationTextAnimationForActiveWritingToolsSession):
(WebKit::TextAnimationController::updateUnderlyingTextVisibilityForTextAnimationID):
(WebKit::TextAnimationController::saveSnapshotOfTextPlaceholderForAnimation):
(WebKit::TextAnimationController::clearAnimationsForActiveWritingToolsSession):

Canonical link: https://commits.webkit.org/283440@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications