[webkit-changes] [WebKit/WebKit] 3907a5: CSS flex shorthand should not eagerly evaluate calc()

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3907a512dae017192970460fc0336cd2b703d3be
      https://github.com/WebKit/WebKit/commit/3907a512dae017192970460fc0336cd2b703d3be
  Author: Sam Weinig <sam at webkit.org>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M LayoutTests/fast/css/flex-calculated-value-expected.txt
    M LayoutTests/fast/css/flex-calculated-value.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-computed.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-invalid.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-valid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-valid.html
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h

  Log Message:
  -----------
  CSS flex shorthand should not eagerly evaluate calc()
https://bugs.webkit.org/show_bug.cgi?id=279395

Reviewed by Tim Nguyen.

Replaces eager evaluation of calc() in CSS flex shorthand consumer with
storing the primitive value for resolution at style building time.

* LayoutTests/fast/css/flex-calculated-value-expected.txt:
* LayoutTests/fast/css/flex-calculated-value.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-computed.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-invalid.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-valid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/parsing/flex-valid.html:
    - Updates tests with calc() cases and new results.

* Source/WebCore/css/parser/CSSPropertyParser.cpp:
    - Replace consumeNumberRaw with consumeNumber.

* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
    - Move isFlexBasis helper to be a lambda in CSSPropertyParser::consumeFlex, its only caller.

Canonical link: https://commits.webkit.org/283437@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications