[webkit-changes] [WebKit/WebKit] c61b4b: [masonry] getComputedStyle should return masonry

[Brandon Stewart]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c61b4bd8c681b8982c2c46af366f6654ac162e2d
      https://github.com/WebKit/WebKit/commit/c61b4bd8c681b8982c2c46af366f6654ac162e2d
  Author: Brandon Stewart <brandonstewart at apple.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent-expected.txt
    M Source/WebCore/css/ComputedStyleExtractor.cpp

  Log Message:
  -----------
  [masonry] getComputedStyle should return masonry
https://bugs.webkit.org/show_bug.cgi?id=279387
rdar://problem/135602712

Reviewed by Sammy Gill.

getComputedStyle() should return a value of masonry when computing grid-template-columns or grid-template-rows.
Returning a px value as we were doing before in the test case is not correct.

https://drafts.csswg.org/css-grid-3/#grid-template-masonry

* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/masonry-grid-template-columns-computed-withcontent-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForGridTrackList):
(WebCore::rendererCanHaveTrimmedMargin):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):

Canonical link: https://commits.webkit.org/283429@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications